CommitTicketUpdater does not honor wiki_format_messages setting

[guttman@…]

When the [changset] wiki_format_messages option is set to false, I would expect that the changset message that gets sent by email and that gets added as a comment to any referenced ticket(s) would be pre-formatted (i.e., not in wiki format). However, this is not the case.

In looking at the code, it seems the option isn't even checked - line 195 of method CommitTicketUpdater.make_ticket_comment() in tracopt/ticket/commit_updater.py:

    def make_ticket_comment(self, repos, changeset):
        """Create the ticket comment from the changeset data."""
        revstring = str(changeset.rev)
        if repos.reponame:
            revstring += '/' + repos.reponame
        return """\
In [%s]:
{{{
#!CommitTicketReference repository="%s" revision="%s"
%s
}}}""" % (revstring, repos.reponame, changeset.rev, changeset.message.strip())
}}}

[anonymous]

Or maybe I just don't understand that the wiki_format_messages option does… Regardless, what I really want is for the changeset emails sent from CommitTicketUpdater to be sent pre-formatted in easy-to-read text.

[anonymous]

This is an visible annoyance bug to users of trac after upgrading to 0.12 that did not exist using the old trac-post-commit hooks and email mechanisms.

[Christian Boos]

Well, the macro is there precisely for rendering the changeset according to the wiki_format_messages (see in tags/trac-0.12/tracopt/ticket//commit_updater.py#expand_macro​ and also #1507 for the background).

So what annoys you is that you see the {{{ / #!CommitTicketReference repository=... / }}} lines in the mail? These could disappear once we have wiki_to_text (#9879) and use that for generating the content of the mails.

[anonymous]

Yes, the / #!CommitTicketReference repository=... / lines in the mail caused multiple complaints by users as soon as we upgraded to trac 0.12. By editing commit_updater.py by editing the lines to keep the original comment and SVN revision number the email output looks like it previously did. And trac still appears to be operating correctly. The addition on the CommitTickReference in the comment in Trac does not appear to perform any additional operations.