Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

Last modified 4 years ago

#9935 closed enhancement (fixed)

[PATCH] Make req parameter to Query.execute() optional

Reported by: chris.nelson.1022@… Owned by: Remy Blank
Priority: high Milestone: 0.12.2
Component: ticket system Version: 0.11.6
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

The req parameter to Query.execute() is no longer required.

Description

Remy Blank invited a patch for this. Here it is. It applies to 0.11.6. I hope it can be trivially cherry-picked to 0.12.

Attachments (1)

query.patch (1.2 KB ) - added by Chris Nelson <Chris.Nelson@…> 9 years ago.
Patch to query.py to make req optional for Query.execute()

Download all attachments as: .zip

Change History (5)

by Chris Nelson <Chris.Nelson@…>, 9 years ago

Attachment: query.patch added

Patch to query.py to make req optional for Query.execute()

comment:1 by Remy Blank, 9 years ago

Milestone: 0.12.2
Owner: set to Remy Blank
Priority: normalhigh

Looks good, thanks. There are a few more quirks in 0.12 due to time fields, but I will take care of that.

comment:2 by Remy Blank, 9 years ago

Resolution: fixed
Status: newclosed

A more complete patch was applied in [10378]. It allows passing the values previously taken from req (namely, authname, tz and href) as arguments to Query.count() and Query.execute(). This should allow running queries outside of a web request context.

comment:3 by Ryan J Ollos, 4 years ago

Reporter: changed from Chris Nelson <Chris.Nelson@…> to Chris Nelson <Chris.Nelson@…>

comment:4 by Ryan J Ollos, 4 years ago

Reporter: changed from Chris Nelson <Chris.Nelson@…> to chris.nelson.1022@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.