Edgewall Software
Modify

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#9931 closed enhancement (fixed)

[PATCH] Raise error when config option can't be found using trac-admin

Reported by: Thijs Triemstra Owned by: Thijs Triemstra
Priority: normal Milestone: 0.12.2
Component: admin/console Version: 0.12-stable
Severity: minor Keywords: patch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Currently trac-admin returns an empty string for the base_url option on a new trac installation. Example:

trac-admin ../test2/ config get trac base_url

When you specify an option that doesn't exist it will return an empty string as well:

trac-admin ../test2/ config get trac base_ur

The attached patch will raise an error when trying to retrieve an option that doesn't exist, making it easier to debug typo's, verify if a config option exists etc.

Attachments (2)

config-option-9931.patch (917 bytes ) - added by Thijs Triemstra 13 years ago.
patch against 0.12-stable r10371
config-option-9931-2.patch (1.8 KB ) - added by Thijs Triemstra 13 years ago.

Download all attachments as: .zip

Change History (7)

by Thijs Triemstra, 13 years ago

Attachment: config-option-9931.patch added

patch against 0.12-stable r10371

comment:1 by Thijs Triemstra, 13 years ago

Result:

trac-admin ../test2/ config get trac base_ur
Error: Option 'base_ur' doesn't exist in section 'trac'

by Thijs Triemstra, 13 years ago

Attachment: config-option-9931-2.patch added

comment:2 by Thijs Triemstra, 13 years ago

Keywords: patch added
Summary: Raise error when config option can't be found using trac-admin[PATCH] Raise error when config option can't be found using trac-admin

Added an updated patch that raises the same error when trying to remove a non-existing config option.

comment:3 by Remy Blank, 13 years ago

Milestone: 0.12.2
Owner: set to Remy Blank

Makes sense.

comment:4 by Remy Blank, 13 years ago

Resolution: fixed
Status: newclosed

Patch applied in [10375]. Thanks!

comment:5 by Remy Blank, 13 years ago

Owner: changed from Remy Blank to Thijs Triemstra

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Thijs Triemstra.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Thijs Triemstra to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.