Unused code: trac.log.logger_factory()

[Carsten Klein <carsten.klein@…>]

The function is currently unused. Is there any reason for keeping it in there?

[Christian Boos]

Unused? Not really:

trac/log.py:0068: def logger_factory(logtype='syslog', logfile=None, level='WARNING',
trac/admin/tests/console.py:0080:         from trac.log import logger_factory
trac/admin/tests/console.py:0081:         self.log = logger_factory('null')
trac/versioncontrol/tests/svn_fs.py:0033: from trac.log import logger_factory

[Christian Boos]

Ok, the last match is an unused import, worth removing.

[Carsten Klein <carsten.klein@…>]

Replying to cboos:

Ok, the last match is an unused import, worth removing.

:D - in effect the previous matches are also worth rethinking if the logger_factory still needs to be in the code, since it is only used by tests.

but this is more or less philosophical…

[Remy Blank]

Unused import removed in [10399]. As for the purpose of logger_factory(), I assume it's for backward compatibility. We could eventually remove it and replace the remaining call with a call to logger_handler_factory().