Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

#9721 closed defect (fixed)

[PATCH] milestone groups do not adhere to 'overall_completion = False'

Reported by: Andrew C Martin <andrew.c.martin@…> Owned by: Remy Blank
Priority: normal Milestone: 0.12.2
Component: roadmap Version: 0.11.6
Severity: minor Keywords: roadmap milestone-groups
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Remy Blank)

As I hinted at in #9718, milestone groups defined in TracIni do not adhere to 'overall_completion = False'. roadmap.py wraps the value of this field in a bool(), which always returns True for a non-empty string.

I have written attachment:overall_completion.patch which I believe corrects this issue.

Reproducible by adding these lines to your trac.ini:

[milestone-groups]
closed = closed
closed.order = 0
closed.overall_completion = true
new = new
new.order = 1
new.css_class = new
new.label = new
new.overall_completion = false
active = *
active.order = 2
active.css_class = open
active.label = in progress

Then observe that 'new' tickets do count towards your completion total.

This is an issue in the current trunk, and I can confirm it existed as of the 0.11.6 branch.

Attachments (2)

overall_completion.patch (1.8 KB ) - added by Andrew C Martin <andrew.c.martin@…> 9 years ago.
trac-0.12-stable-r10436-inverted-booleans.diff (1.4 KB ) - added by Christopher A. Stelma <chris@…> 9 years ago.
fix for two inverted booleans from r10308

Download all attachments as: .zip

Change History (9)

by Andrew C Martin <andrew.c.martin@…>, 9 years ago

Attachment: overall_completion.patch added

in reply to:  description comment:1 by Andrew C Martin <andrew.c.martin@…>, 9 years ago

Replying to Andrew C Martin <andrew.c.martin@…>:

Then observe that 'new' tickets don't count towards your completion total.

That should read "Then observe that 'new' tickets do count towards your completion total."

comment:2 by Remy Blank, 9 years ago

Description: modified (diff)
Milestone: 0.12.2
Owner: set to Remy Blank

Thanks for the patch.

comment:3 by Stefan, 9 years ago

Version: 0.12dev0.11.6

can confirm it's a 0.11.6 issue as well and hence updated the version to reflect that being a 0.11.6 bug.

comment:4 by Remy Blank, 9 years ago

The fix is actually quite a bit simpler if you accept to import the "private" variable _TRUE_VALUES from trac.config. I have applied this simple fix in [10307].

But _TRUE_VALUES is used too much (and often badly, as case is often neglected). We already have trac.util.as_bool(), so I'll adapt it to be "compatible" and just use it everywhere.

comment:5 by Remy Blank, 9 years ago

Resolution: fixed
Status: newclosed

The uses of _TRUE_VALUES have been refactored in [10308].

by Christopher A. Stelma <chris@…>, 9 years ago

fix for two inverted booleans from r10308

in reply to:  5 ; comment:6 by Christopher A. Stelma <chris@…>, 9 years ago

Resolution: fixed
Status: closedreopened

Replying to rblank:

The uses of _TRUE_VALUES have been refactored in [10308].

this inverted two of the booleans, I noticed this because now only hidden repositories show in the timeline filter list (the opposite of expected behavior). fix in trac-0.12-stable-r10436-inverted-booleans.diff

in reply to:  6 comment:7 by Remy Blank, 9 years ago

Resolution: fixed
Status: reopenedclosed

Replying to Christopher A. Stelma <chris@…>:

this inverted two of the booleans,

Oops, good catch! Patch applied in [10437]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.