Edgewall Software
Modify

Opened 12 years ago

Last modified 2 years ago

#9677 new defect

Expanding an alias repository sets the hash to the aliased repository

Reported by: Remy Blank Owned by:
Priority: normal Milestone: next-stable-1.4.x
Component: version control/browser Version: 0.12-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When expanding a named repository alias in the repository index, the URL hash is set to the aliased repository instead of the alias. Therefore, when reloading a page with an expanded alias, the aliased repository is expanded instead.

This is due to toggleDir() using the anchor href to determine the path. For aliases, the href points to the aliased repository. We could instead reconstruct the path by using the anchor text() and walking up the table to find the containing directories.

Attachments (0)

Change History (8)

in reply to:  description comment:1 by Christian Boos, 12 years ago

Replying to rblank:

… For aliases, the href points to the aliased repository.

Isn't it rather this, the problem to fix?

comment:2 by Remy Blank, 12 years ago

This was intentional. We agreed at some point that aliases should only be pointers, and any link to an alias should actually point to the real repository. Note also that viewing a /browser/repo-alias link redirects to /browser/repo.

This redirection, if we decided to set the href to the alias, would play tricks with XMLHttpRequests, as the initial request would be identified as an xhr, but not the redirected request, so you end up seeing the repository index page below the repository entry :(

comment:3 by Christian Boos, 12 years ago

Okay, but then if it really is like that (aliases should be only pointers), is the current behavior (when reloading a page with an expanded alias, the aliased repository is expanded instead) so problematic?

comment:4 by Remy Blank, 12 years ago

It's not really problematic (or rather, it's cosmetic), except when the aliased repository is hidden. In that case, nothing expands on reload. Again, it's cosmetic, but having a good idea how to fix it, I'd rather do it :)

comment:5 by Ryan J Ollos, 8 years ago

Milestone: next-minor-0.12.xnext-stable-1.0.x

comment:6 by Ryan J Ollos, 7 years ago

Owner: Remy Blank removed

comment:7 by Ryan J Ollos, 6 years ago

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

comment:8 by Ryan J Ollos, 2 years ago

Milestone: next-stable-1.2.xnext-stable-1.4.x

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.