Expanding an alias repository sets the hash to the aliased repository

[Remy Blank]

When expanding a named repository alias in the repository index, the URL hash is set to the aliased repository instead of the alias. Therefore, when reloading a page with an expanded alias, the aliased repository is expanded instead.

This is due to toggleDir()​ using the anchor href to determine the path. For aliases, the href points to the aliased repository. We could instead reconstruct the path by using the anchor text() and walking up the table to find the containing directories.

[Christian Boos]

Replying to rblank:

… For aliases, the href points to the aliased repository.

Isn't it rather this, the problem to fix?

[Remy Blank]

This was intentional. We agreed at some point that aliases should only be pointers, and any link to an alias should actually point to the real repository. Note also that viewing a /browser/repo-alias link redirects to /browser/repo.

This redirection, if we decided to set the href to the alias, would play tricks with XMLHttpRequests, as the initial request would be identified as an xhr, but not the redirected request, so you end up seeing the repository index page below the repository entry :(

[Christian Boos]

Okay, but then if it really is like that (aliases should be only pointers), is the current behavior (when reloading a page with an expanded alias, the aliased repository is expanded instead) so problematic?

[Remy Blank]

It's not really problematic (or rather, it's cosmetic), except when the aliased repository is hidden. In that case, nothing expands on reload. Again, it's cosmetic, but having a good idea how to fix it, I'd rather do it :)

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed