Edgewall Software
Modify ↓

Opened 14 years ago

Closed 14 years ago

#9669 closed defect (fixed)

TypeError when selecting "diff" on a modified comment in a ticket

Reported by: ID Owned by: Christian Boos
Priority: normal Milestone: 0.12.1
Component: ticket system Version: 0.12
Severity: normal Keywords: TypeError, diff, comment
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

The exact error: 

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/trac/web/api.py", line 436, in send_error
    data, 'text/html')
  File "/usr/lib/python2.6/site-packages/trac/web/chrome.py", line 844, in render_template
    stream.render(method, doctype=doctype, out=buffer)
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 183, in render
    return encode(generator, method=method, encoding=encoding, out=out)
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 58, in encode
    for chunk in iterator:
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 339, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 826, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 670, in __call__
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 771, in __call__
    for kind, data, pos in chain(stream, [(None, None, None)]):
  File "/usr/lib/python2.6/site-packages/genshi/output.py", line 586, in __call__
    for ev in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/trac/web/chrome.py", line 945, in _strip_accesskeys
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/trac/web/chrome.py", line 934, in _generate
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 605, in _include
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/template/markup.py", line 378, in _match
    ctxt, start=idx + 1, **vars):
  File "/usr/lib/python2.6/site-packages/genshi/template/markup.py", line 378, in _match
    ctxt, start=idx + 1, **vars):
  File "/usr/lib/python2.6/site-packages/genshi/template/markup.py", line 327, in _match
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 545, in _flatten
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/path.py", line 588, in _generate
    subevent = next()
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 605, in _include
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/template/markup.py", line 316, in _strip
    event = next()
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 545, in _flatten
    for kind, data, pos in stream:
  File "/usr/lib/python2.6/site-packages/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/path.py", line 588, in _generate
    subevent = next()
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 605, in _include
    for event in stream:
  File "/usr/lib/python2.6/site-packages/genshi/template/markup.py", line 316, in _strip
    event = next()
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 565, in _flatten
    result = _eval_expr(data, ctxt, vars)
  File "/usr/lib/python2.6/site-packages/genshi/template/base.py", line 277, in _eval_expr
    retval = expr.evaluate(ctxt)
  File "/usr/lib/python2.6/site-packages/genshi/template/eval.py", line 178, in evaluate
    return eval(self.code, _globals, {'__data__': data})
  File "/usr/lib/python2.6/site-packages/trac/templates/error.html", line 165, in <Expression u'shorten_line(repr(value))'>
    <td><code>${shorten_line(repr(value))}</code></td>
  File "/usr/lib/python2.6/site-packages/trac/resource.py", line 118, in __repr__
    return '<Resource %r>' % (', '.join(reversed(path)))
TypeError: sequence item 0: expected string, Ticket found

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 14 years ago

Description: modified (diff)

Is there anything in the Trac log prior to that error? The above is a secondary error happening during error rendering, the log could show us the original error.

(and btw, I didn't modify anything in the description… strange - server at r10140)

Last edited 14 years ago by Christian Boos (previous) (diff)

comment:2 by ID, 14 years ago

The ticket_policy is the last DEBUG message: 

2010-10-06 09:09:08,788 Trac[ticket_policy] DEBUG: Internal: action:BROWSER_VIEW, user:********, resource:<Resource u'repository, source:/'>, perm: <trac.perm.PermissionCache object at 0x8cb4374>
2010-10-06 09:09:08,788 Trac[ticket_policy] DEBUG: Internal: action:WIKI_VIEW, user:********, resource:<Resource 'wiki'>, perm: <trac.perm.PermissionCache object at 0x8cb42d4>
2010-10-06 09:09:08,799 Trac[ticket_policy] DEBUG: Internal: action:EMAIL_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x8787edc>
2010-10-06 09:09:08,844 Trac[reports_filter] DEBUG: ReportScreenFilter: self.billing_reports= set([9, 10, 11, 12, 13, 14, 15, 16, 17])
2010-10-06 09:09:08,844 Trac[blackmagic] DEBUG: IN BlackMagic
2010-10-06 09:09:08,844 Trac[blackmagic] DEBUG: Not a ticket returning
2010-10-06 09:09:08,844 Trac[tande_filters] DEBUG: TicketFormatFilter executing
2010-10-06 09:09:08,844 Trac[tande_filters] DEBUG: TicketFormatFilter not the correct template
2010-10-06 09:09:08,844 Trac[tande_filters] DEBUG: Not a query returning
2010-10-06 09:09:08,844 Trac[ticket_webui] DEBUG: TicketWebUiAddon executing
2010-10-06 09:09:22,994 Trac[env] INFO: -------------------------------- environment startup [Trac 0.12] --------------------------------
2010-10-06 09:09:23,021 Trac[loader] DEBUG: Loading CustomRoadmap from /usr/lib/python2.6/site-packages/TracCustomRoadmap-0.4-py2.6.egg
2010-10-06 09:09:23,103 Trac[loader] DEBUG: Loading TracBurndown from /usr/lib/python2.6/site-packages/TracBurndown-1.9.1-py2.6.egg
2010-10-06 09:09:23,105 Trac[loader] DEBUG: Loading TracNav from /usr/lib/python2.6/site-packages/TracNav-4.2.dev_r3275-py2.6.egg
2010-10-06 09:09:23,106 Trac[loader] DEBUG: Loading TracSVNAuthz from /usr/lib/python2.6/site-packages/TracSVNAuthz-0.11.1.1-py2.6.egg
2010-10-06 09:09:23,108 Trac[loader] DEBUG: Loading TracXMLRPC from /usr/lib/python2.6/site-packages/TracXMLRPC-1.1.0_r7971-py2.6.egg
2010-10-06 09:09:23,156 Trac[loader] DEBUG: Loading acct_mgr.admin from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,167 Trac[loader] DEBUG: Loading acct_mgr.api from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,167 Trac[loader] DEBUG: Loading acct_mgr.db from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,169 Trac[loader] DEBUG: Loading acct_mgr.htfile from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,169 Trac[loader] DEBUG: Loading acct_mgr.http from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,170 Trac[loader] DEBUG: Loading acct_mgr.notification from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,171 Trac[loader] DEBUG: Loading acct_mgr.pwhash from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,171 Trac[loader] DEBUG: Loading acct_mgr.svnserve from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,171 Trac[loader] DEBUG: Loading acct_mgr.web_ui from /usr/lib/python2.6/site-packages/TracAccountManager-0.2.1dev_r7737-py2.6.egg
2010-10-06 09:09:23,172 Trac[loader] DEBUG: Loading graphviz from /usr/lib/python2.6/site-packages/graphviz-0.7.6dev-py2.6.egg
2010-10-06 09:09:23,173 Trac[loader] DEBUG: Loading httpauth.filter from /usr/lib/python2.6/site-packages/TracHTTPAuth-1.1-py2.6.egg
2010-10-06 09:09:23,175 Trac[loader] DEBUG: Loading includemacro.macros from /usr/lib/python2.6/site-packages/TracIncludeMacro-2.1-py2.6.egg
2010-10-06 09:09:23,177 Trac[loader] DEBUG: Loading iniadmin from /usr/lib/python2.6/site-packages/IniAdmin-0.2-py2.6.egg
2010-10-06 09:09:23,178 Trac[loader] DEBUG: Loading permredirect.filter from /usr/lib/python2.6/site-packages/TracPermRedirect-2.0-py2.6.egg
2010-10-06 09:09:23,186 Trac[loader] DEBUG: Loading sequencediagram.macro from /usr/lib/python2.6/site-packages/SequenceDiagram-1.0-py2.6.egg
2010-10-06 09:09:23,187 Trac[loader] DEBUG: Loading timingandestimationplugin from /usr/lib/python2.6/site-packages/timingandestimationplugin-1.0.6b-py2.6.egg
2010-10-06 09:09:23,203 Trac[loader] DEBUG: Loading trac.about from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,205 Trac[loader] DEBUG: Loading trac.admin.console from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,212 Trac[loader] DEBUG: Loading trac.admin.web_ui from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,213 Trac[loader] DEBUG: Loading trac.attachment from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,213 Trac[loader] DEBUG: Loading trac.db.mysql from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,218 Trac[loader] DEBUG: Loading trac.db.postgres from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,222 Trac[loader] DEBUG: Loading trac.db.sqlite from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,228 Trac[loader] DEBUG: Loading trac.mimeview.patch from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,233 Trac[loader] DEBUG: Loading trac.mimeview.pygments from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,284 Trac[loader] DEBUG: Loading trac.mimeview.rst from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,503 Trac[loader] DEBUG: Loading trac.mimeview.silvercity from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,515 Trac[loader] DEBUG: Skipping "trac.mimeview.silvercity = trac.mimeview.silvercity [silvercity]": ("DistributionNotFound: SilverCity>=0.9.4" not found)
2010-10-06 09:09:23,515 Trac[loader] DEBUG: Loading trac.mimeview.txtl from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,527 Trac[loader] DEBUG: Skipping "trac.mimeview.txtl = trac.mimeview.txtl [textile]": ("DistributionNotFound: textile>=2.0" not found)
2010-10-06 09:09:23,528 Trac[loader] DEBUG: Loading trac.prefs from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,530 Trac[loader] DEBUG: Loading trac.search from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,531 Trac[loader] DEBUG: Loading trac.ticket.admin from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,543 Trac[loader] DEBUG: Loading trac.ticket.query from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,544 Trac[loader] DEBUG: Loading trac.ticket.report from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,544 Trac[loader] DEBUG: Loading trac.ticket.roadmap from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,544 Trac[loader] DEBUG: Loading trac.ticket.web_ui from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,545 Trac[loader] DEBUG: Loading trac.timeline from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,551 Trac[loader] DEBUG: Loading trac.versioncontrol.admin from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,552 Trac[loader] DEBUG: Loading trac.versioncontrol.svn_authz from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,555 Trac[loader] DEBUG: Loading trac.versioncontrol.svn_fs from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,572 Trac[loader] DEBUG: Loading trac.versioncontrol.svn_prop from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,617 Trac[loader] DEBUG: Loading trac.versioncontrol.web_ui from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,617 Trac[loader] DEBUG: Loading trac.web.auth from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,617 Trac[loader] DEBUG: Loading trac.web.session from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,618 Trac[loader] DEBUG: Loading trac.wiki.admin from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,618 Trac[loader] DEBUG: Loading trac.wiki.interwiki from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,622 Trac[loader] DEBUG: Loading trac.wiki.macros from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,622 Trac[loader] DEBUG: Loading trac.wiki.web_api from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,623 Trac[loader] DEBUG: Loading trac.wiki.web_ui from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,633 Trac[loader] DEBUG: Loading tracopt.mimeview.enscript from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,635 Trac[loader] DEBUG: Loading tracopt.mimeview.php from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,635 Trac[loader] DEBUG: Loading tracopt.perm.authz_policy from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,636 Trac[loader] DEBUG: Loading tracopt.perm.config_perm_provider from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,637 Trac[loader] DEBUG: Loading tracopt.ticket.commit_updater from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,638 Trac[loader] DEBUG: Loading tracopt.ticket.deleter from /usr/lib/python2.6/site-packages
2010-10-06 09:09:23,639 Trac[loader] DEBUG: Loading tracwysiwyg from /usr/lib/python2.6/site-packages/TracWysiwyg-0.12.0.2_r8148-py2.6.egg
2010-10-06 09:09:23,640 Trac[loader] DEBUG: Loading wikistats.pagecount from /usr/lib/python2.6/site-packages/TracWikiStats-0.1-py2.6.egg
2010-10-06 09:09:23,641 Trac[loader] DEBUG: Loading wikistats.stats from /usr/lib/python2.6/site-packages/TracWikiStats-0.1-py2.6.egg
2010-10-06 09:09:23,641 Trac[loader] DEBUG: Loading wikistats.usercount from /usr/lib/python2.6/site-packages/TracWikiStats-0.1-py2.6.egg
2010-10-06 09:09:23,647 Trac[default_workflow] DEBUG: Workflow actions at initialization: {u'hold': {'operations': [], u'name': u'Set on hold', 'default': 0, 'newstate': u'on_hold', 'oldstates': [u'new', u'assigned', u'accepted', u'needs_work'], u'permissions': [u'TICKET_MODIFY']}, u'reopen': {u'operations': [u'del_resolution'], 'name': u'reopen', 'default': 0, 'newstate': u'needs_work', 'oldstates': [u'closed'], u'permissions': [u'TICKET_CREATE']}, u'reject': {u'operations': [u'set_owner'], u'name': u'Failed testing, return', 'default': 0, 'newstate': u'needs_work', 'oldstates': [u'testing'], 'permissions': []}, u'accept': {u'operations': [u'set_owner_to_self'], 'name': u'accept', 'default': 0, 'newstate': u'accepted', 'oldstates': [u'new', u'assigned', u'needs_work', u'on_hold'], u'permissions': [u'TICKET_MODIFY']}, u'leave': {u'operations': [u'leave_status'], 'name': u'leave', u'default': 1, 'newstate': u'*', 'oldstates': [u'*'], 'permissions': []}, u'reassign': {u'operations': [u'set_owner'], 'name': u'reassign', 'default': 0, 'newstate': u'assigned', 'oldstates': [u'new', u'assigned', u'accepted', u'needs_work', u'on_hold'], u'permissions': [u'TICKET_MODIFY']}, u'pass': {u'operations': [u'set_resolution'], u'name': u'Close', 'default': 0, 'newstate': u'closed', 'oldstates': [u'new', u'testing', u'assigned'], u'permissions': [u'TICKET_MODIFY']}, u'test': {u'operations': [u'set_resolution', u'set_owner'], u'name': u'Submit for testing', 'default': 0, 'newstate': u'testing', 'oldstates': [u'new', u'assigned', u'accepted', u'needs_work', u'testing', u'on_hold', u'test_on_hold'], u'permissions': [u'TICKET_MODIFY']}, u'testhold': {u'operations': [u'set_owner'], u'name': u'Set test on hold', 'default': 0, 'newstate': u'test_on_hold', 'oldstates': [u'testing'], u'permissions': [u'TICKET_MODIFY']}, '_reset': {'operations': ['reset_workflow'], 'name': 'reset', 'default': 0, 'newstate': 'new', 'oldstates': [], 'permissions': []}}

2010-10-06 09:09:23,649 Trac[reportmanager] DEBUG: T&E Starting Report Schema Upgrade
2010-10-06 09:09:23,661 Trac[reportmanager] DEBUG: T&E Ending Report Schema Upgrade
2010-10-06 09:09:23,669 Trac[api] DEBUG: T&E NEEDS UP?: sys:False, rep:False, stats:False, fields:False, man:False
2010-10-06 09:09:23,669 Trac[main] DEBUG: Dispatching <Request "GET '/ticket/3567'">
2010-10-06 09:09:23,671 Trac[graphviz] INFO: version: 0.7.5dev - id: $Id: graphviz.py 5900 2009-05-30 11:05:08Z cboos $
2010-10-06 09:09:23,693 Trac[svn_fs] DEBUG: Subversion bindings imported
2010-10-06 09:09:23,696 Trac[api] INFO: Synchronized '' repository in 0.02 seconds
2010-10-06 09:09:23,697 Trac[web_ui] DEBUG: Updating session a388a8beffade55798c4ae8b2501994a for user ********
2010-10-06 09:09:23,704 Trac[session] DEBUG: Retrieving session for ID u'********'
2010-10-06 09:09:23,705 Trac[web_ui] DEBUG: Updating session a388a8beffade55798c4ae8b2501994a for user ********
2010-10-06 09:09:23,716 Trac[ticket_policy] DEBUG: Internal: action:TICKET_VIEW, user:********, resource:<Resource u'ticket:3567@1'>, perm: <trac.perm.PermissionCache object at 0x8aaf874>
2010-10-06 09:09:23,716 Trac[api] DEBUG: action controllers for ticket workflow: ['ConfigurableTicketWorkflow']
2010-10-06 09:09:23,724 Trac[ticket_policy] DEBUG: Internal: RESULTS for TICKET_VIEW: None
2010-10-06 09:09:23,729 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/trac/web/main.py", line 513, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.6/site-packages/trac/web/main.py", line 235, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 169, in process_request
    return self._process_ticket_request(req)
  File "/usr/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 474, in _process_ticket_request
    return self._render_comment_diff(req, ticket, data, cnum)
  File "/usr/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 923, in _render_comment_diff
    req.perm(ticket).require('TICKET_VIEW')
  File "/usr/lib/python2.6/site-packages/trac/perm.py", line 575, in require
    if not self._has_permission(action, resource):
  File "/usr/lib/python2.6/site-packages/trac/perm.py", line 567, in _has_permission
    check_permission(action, perm.username, resource, perm)
  File "/usr/lib/python2.6/site-packages/trac/perm.py", line 454, in check_permission
    perm)
  File "/usr/lib/python2.6/site-packages/timingandestimationplugin-1.0.6b-py2.6.egg/timingandestimationplugin/ticket_policy.py", line 15, in check_permission
    ( action, username, resource, perm))
  File "/usr/lib/python2.6/site-packages/trac/resource.py", line 118, in __repr__
    return '<Resource %r>' % (', '.join(reversed(path)))
TypeError: sequence item 0: expected string, Ticket found
2010-10-06 09:09:23,730 Trac[ticket_policy] DEBUG: Internal: action:TRAC_ADMIN, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,822 Trac[chrome] DEBUG: Prepare chrome data for request
2010-10-06 09:09:23,823 Trac[ticket_policy] DEBUG: Internal: action:TICKET_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,824 Trac[ticket_policy] DEBUG: Internal: action:ROADMAP_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,824 Trac[ticket_policy] DEBUG: Internal: action:XML_RPC, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,825 Trac[ticket_policy] DEBUG: Internal: action:TICKET_CREATE, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,825 Trac[ticket_policy] DEBUG: Internal: action:SEARCH_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,826 Trac[ticket_policy] DEBUG: Internal: action:PERMISSION_GRANT, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,827 Trac[ticket_policy] DEBUG: Internal: action:TICKET_ADMIN, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,827 Trac[ticket_policy] DEBUG: Internal: action:MILESTONE_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,827 Trac[ticket_policy] DEBUG: Internal: action:VERSIONCONTROL_ADMIN, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,828 Trac[ticket_policy] DEBUG: Internal: action:REPORT_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,828 Trac[ticket_policy] DEBUG: Internal: action:TIME_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,829 Trac[ticket_policy] DEBUG: Internal: action:TIMELINE_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,829 Trac[ticket_policy] DEBUG: Internal: action:BROWSER_VIEW, user:********, resource:<Resource u'repository, source:/'>, perm: <trac.perm.PermissionCache object at 0x8e79a2c>
2010-10-06 09:09:23,830 Trac[ticket_policy] DEBUG: Internal: action:WIKI_VIEW, user:********, resource:<Resource 'wiki'>, perm: <trac.perm.PermissionCache object at 0x8e79a2c>
2010-10-06 09:09:23,831 Trac[ticket_policy] DEBUG: Internal: action:EMAIL_VIEW, user:********, resource:None, perm: <trac.perm.PermissionCache object at 0x880bb94>
2010-10-06 09:09:23,881 Trac[reports_filter] DEBUG: ReportScreenFilter: self.billing_reports= set([9, 10, 11, 12, 13, 14, 15, 16, 17])
2010-10-06 09:09:23,882 Trac[blackmagic] DEBUG: IN BlackMagic
2010-10-06 09:09:23,882 Trac[blackmagic] DEBUG: Not a ticket returning
2010-10-06 09:09:23,882 Trac[tande_filters] DEBUG: TicketFormatFilter executing
2010-10-06 09:09:23,882 Trac[tande_filters] DEBUG: TicketFormatFilter not the correct template
2010-10-06 09:09:23,882 Trac[tande_filters] DEBUG: Not a query returning
2010-10-06 09:09:23,882 Trac[ticket_webui] DEBUG: TicketWebUiAddon executing
2010-10-06 09:09:24,040 Trac[blackmagic] DEBUG: IN BlackMagic
2010-10-06 09:09:24,040 Trac[blackmagic] DEBUG: Not a ticket returning
2010-10-06 09:09:24,040 Trac[tande_filters] DEBUG: TicketFormatFilter executing
2010-10-06 09:09:24,040 Trac[tande_filters] DEBUG: TicketFormatFilter not the correct template
2010-10-06 09:09:24,040 Trac[tande_filters] DEBUG: Not a query returning
2010-10-06 09:09:24,040 Trac[ticket_webui] DEBUG: TicketWebUiAddon executing

comment:3 by Christian Boos, 14 years ago

Milestone: next-minor-0.12.x → 0.12.1
Owner: set to Christian Boos
Priority: low → normal 
  File "/usr/lib/python2.6/site-packages/trac/ticket/web_ui.py", line 923, in _render_comment_diff
    req.perm(ticket).require('TICKET_VIEW')

Oops ;-)

Thanks for the report!

Could you please verify the following fix?

  • trac/ticket/web_ui.py

     
    923923
    924924    def _render_comment_diff(self, req, ticket, data, cnum):
    925925        """Show differences between two versions of a ticket comment."""
    926         req.perm(ticket).require('TICKET_VIEW')
     926        req.perm(ticket.resource).require('TICKET_VIEW')
    927927        new_version = int(req.args.get('version', 1))
    928928        old_version = int(req.args.get('old_version', new_version))
    929929        if old_version > new_version:

comment:4 by ID, 14 years ago

Yes, that works! ;-)

comment:5 by Christian Boos, 14 years ago

Resolution: → fixed
Status: new → closed

Thanks for verifying! (though I had little doubts on this one ;-) )

Applied in r10194.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.