[PATCH] __color__ column in csv reports

[Thijs Triemstra <lists@…>]

On a new Trac instance ​http://localhost:8080/report/1?asc=1&format=csv returns a __color__ column for csv reports:

__color__,ticket,summary,component,version,milestone,type,owner,status,created,_changetime,_description,_reporter
3,1,sdsad,component1,,,defect,somebody,new,2010-09-29T00:10:30+02:00,2010-09-29T00:48:11+02:00,[[TracAdminHelp(upgrade)]],admin
3,2,sdsadsa,component1,,,defect,somebody,new,2010-09-29T00:10:36+02:00,2010-09-29T00:10:36+02:00,dsadsdsadasdas,admin
3,3,sadsadsdasdas,component1,,,defect,somebody,new,2010-09-29T00:10:43+02:00,2010-09-29T00:10:43+02:00,sadsadasd,admin

[Thijs Triemstra <lists@…>]

remove color property

[Remy Blank]

I'll apply that, thanks.

[Thijs Triemstra <lists@…>]

The previous patch didn't remove the row's first cell, only the column header, this patch should fix that (and also exclude other style-related rows):

trac/ticket/report.py

@@ -478 +478 @@
         #  - group rows according to __group__ value, if defined
         #  - group cells the same way headers are grouped
         row_groups = []
-        authorized_results = [] 
+        authorized_results = []
+        extra_row_props = ['__style__', '__color__', '__fgcolor__',
+                           '__bgcolor__', '__grouplink__']
         prev_group_value = None
         for row_idx, result in enumerate(results):
             col_idx = 0
@@ -501 +503 @@
                             (Chrome(self.env).format_author(req, value), []) )
                     # Other row properties
                     row['__idx__'] = row_idx
-                    if col in ('__style__', '__color__',
-                               '__fgcolor__', '__bgcolor__',
-                               '__grouplink__'):
+                    if col in extra_row_props:
                         row[col] = value
                     if col in ('report', 'ticket', 'id', '_id'):
                         row['id'] = value
@@ -539 +539 @@
                      'numrows': numrows,
                      'sorting_enabled': len(row_groups) == 1})
 
+        if format == 'csv' or format == 'tab':
+            for exclude in extra_row_props:
+                try:
+                    clr = cols.index(exclude)
+                    cols.pop(clr)
+                    for row in authorized_results:
+                        row.pop(clr)
+                except ValueError:
+                    pass
+
         if format == 'rss':
             data['email_map'] = Chrome(self.env).get_email_map()
             data['context'] = Context.from_request(req, report_resource,

[Remy Blank]

Different fix, directly in _send_csv().

[Remy Blank]

Could you please test 9667-special-cols-r10233.patch​? It solves the issue slightly differently, by filtering the columns in _send_csv(), so it doesn't have to mutate all results.

[Thijs Triemstra <lists@…>]

Thanks, that patch is much cleaner and works properly on ​http://localhost:8000/trac-test-instance/report/1?asc=1&format=csv. If I check the 'My Tickets' link on ​http://localhost:8000/trac-test-instance/report/7 it contains a __group__ column. Even though it it's not part of this ticket description, would be nice to get rid of that one as well.

[Remy Blank]

Thanks for testing. About the __group__ column, it could be removed easily by adding it to the _special_cols set, but I'm not sure this is desired.

All other special columns only have meaning when rendered as HTML. The __group__ column, however, represents the grouping information for the report, and removing it changes the meaning of the report. So I would rather leave it in.

Patch above (with a small change in name to better identify the removed special columns) applied in [10247].