Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9656 closed defect (fixed)

[PATCH] Strip spaces in usernames when defining permissions

Reported by: erny@… Owned by: Mikael Relbe
Priority: normal Milestone: 0.12.2
Component: admin/web Version: 0.12-stable
Severity: normal Keywords: permissions, bitesized
Cc: mikael@…
Release Notes:

admin: in permissions panel, strip whitespace around user and group names

API Changes:

Description

When adding user to groups in /admin/general/perm spaces at the end of usernames are not stripped. The effect is that the indented user has not the correct permissions assigned.

Attachments (1)

t9656_strip-user-group-name-10198.patch (631 bytes ) - added by Mikael Relbe 8 years ago.
Strips user and group names in perm. admin panel, apply on trunk r10198

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Remy Blank

Keywords: bitesized added
Milestone: next-minor-0.12.x
Owner: set to Remy Blank

Sounds simple enough. PatchWelcome.

Changed 8 years ago by Mikael Relbe

Strips user and group names in perm. admin panel, apply on trunk r10198

comment:2 in reply to:  1 Changed 8 years ago by Mikael Relbe

Cc: mikael@… added
Milestone: next-minor-0.12.x0.12.2
Summary: Strip spaces in usernames when defining permissions[PATCH] Strip spaces in usernames when defining permissions

Replying to rblank:

Sounds simple enough. PatchWelcome.

You're welcome ;)

comment:3 Changed 8 years ago by Remy Blank

Resolution: fixed
Status: newclosed

Applied in [10210]. Thanks!

comment:4 Changed 8 years ago by Remy Blank

Owner: changed from Remy Blank to Mikael Relbe

comment:5 Changed 8 years ago by Christian Boos

Release Notes: modified (diff)
Type: enhancementdefect

Requalifying as bug fix, as it was borderline anyway and we said no enhancements on 0.12.2, yesterday, right? ;-)

comment:6 in reply to:  description ; Changed 8 years ago by Christian Boos

Replying to erny@…:

The effect is that the indented user has not the correct permissions assigned.

Perhaps because the indented user was not the intended one? ;-)

comment:7 in reply to:  6 Changed 8 years ago by Mikael Relbe

Replying to cboos:

Perhaps because the indented user was not the intended one? ;-)

That caused me an IRL laugh, thanks!

I also realize that I made a mistake in comment:2: I addressed the ticket to 0.12.2, which corresponds to branches/0.12-stable, but the patch itself was for trunk… Pure luck this time, I'll try to behave in the future :)

comment:8 in reply to:  6 Changed 8 years ago by Remy Blank

Replying to cboos:

Replying to erny@…:

The effect is that the indented user has not the correct permissions assigned.

Perhaps because the indented user was not the intended one? ;-)

Too much Python can be bad for your health :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Mikael Relbe.
The resolution will be deleted.
to The owner will be changed from Mikael Relbe to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.