Opened 14 years ago
Closed 11 years ago
#9590 closed defect (worksforme)
Display of Patch/Diff file broken
| Reported by: | hakre | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | rendering | Version: | 0.11.7 |
| Severity: | major | Keywords: | diff verify |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
When looking into an attachment that is a patch file that contains changes to PHP code that is related to Diff, it looks like trac has problems to properly display that patchfile. It just stops somewhere in between.
Example: http://core.trac.wordpress.org/attachment/ticket/14726/14726.2.patch
Attachments (2)
Change History (7)
by , 14 years ago
comment:1 by , 14 years ago
I needed to replace the original patch file of the example so making the example link not work any longer. To check, I've attached that original patch file here. I needed to put it in a zip otherwise it was reported as spam.
comment:3 by , 14 years ago
| Component: | general → rendering |
|---|---|
| Keywords: | verify added |
IIUC, the problem is with wp-includes/class-snoopy.php, which displays fine here, but not on core.trac.wordpress.org.
Maybe due to the default_encoding setting?
comment:4 by , 14 years ago
| Keywords: | diff added |
|---|---|
| Milestone: | → next-minor-0.12.x |
| Severity: | normal → major |
comment:5 by , 11 years ago
| Milestone: | next-minor-0.12.x |
|---|---|
| Resolution: | → worksforme |
| Status: | new → closed |
Looks like the reported problematic link look fine now. They're now running 0.12.4, so I assume this must have been fixed along the way.
example file that originally broke - patch on example page has been replaced