[PATCH] Irrelevant error on trac.log permission issue

[andre.miras@…]

Hi, I spent ages trying to understand what was behind a "Command not found" error while running the following command from the shell (for debugging git post-receive hooks):

trac-admin '/home/myuser/trac/project1/' 'changeset' 'added' '(default)' '2dd5db7daecab8a08a17de4f5e603d14db4125a0'

In my particular case, the expected output should had been:

IOError: [Errno 13] Permission denied: u'/var/log/trac.log'

This is because the exception raised by logger_handler_factory in trac/env.py(468)setup_log() is handled upper in trac/admin/console.py(151)env_check(). I think it should really be raised or handled in a more proper way so a trac administrator won't spend ages trying to figure out what is that wired "Command not found" message after his git push.

By prospecting on the web we can see that "Command not found" must be a permission which was right but irrelevant. As the user owning my TRAC_ENV (myuseer) is different as the user hosting git (git). I tried to give my git user a rwx access to my TRAC_ENV, after what I still got the issue.

And it's only after doing further investigation using pdb that I found out the permission issue came from my trac.log which stands in /var/log/trac.log After giving git a rw access to it, everything worked ok.

Additional informations: OS: Gentoo Linux Python 2.6.2 Trac 0.12 Trac git r8215 Debugging output attached

[andre.miras@…]

pdb output

[Remy Blank]

Yes, that part of trac-admin could be improved. Another improvement would be to use the same open_environment() machinery as for web request processing, including reloading the environment when required (e.g. on configuration changes).

[Remy Blank]

The refactoring in comment:1 would be an enhancement for a major release.

[Sebastian Krysmanski <sebastian@…>]

Patch against Trac 0.12.1

[Sebastian Krysmanski <sebastian@…>]

Patch against Trac 0.12.1 (allows empty directories)

[Sebastian Krysmanski <sebastian@…>]

I've included a patch that does exactly what the reporter want. It's not major rewrite, though, but this way this could get into the next minor release.

The patch itself is not very well arranged (but the result of the patch is), so I'm just losing some words on what I've changed:

The original implementation silently ignored all exceptions that were raised in the environment initialization propably because it should work when the environment hasn't been created yet. However this results in no clues whatsoever when something is wrong with the environment (especiallly permission problems) but makes trac-admin appear as if there were no environment.

So with my patch the only possibility for trac-admin to recognize an environment as "not existing" is if the directory doesn't exist or if it's empty. I'm not 100% sure but currently I can't think of any other situation in which a non-empty directory should be considered a "not existing" Trac environment.

Other than that there's only one API change in my patch. It regards env_set() where I've removed the env parameter (what's the user case for specifying an environment separated from its path?) and added a new parameter do_env_check which does the environment check directly inside env_set(). This way the user is immediately notified if something is wrong with the environment.

[Thijs Triemstra]

This patch needs a review.

[Remy Blank]

Refocusing.

[Jun Omae]

Trac 0.12.3 doesn't have the issue, but 0.12.2 has the issue. I suppose this is fixed in [10856].

jun66j5@gotanda:774$ hg update -r trac-0.12.3
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
jun66j5@gotanda:775$ chmod a-w ~/var/trac/0.12-stable/log/trac.log
jun66j5@gotanda:776$ PYTHONPATH=$PWD python2.4 trac/admin/console.py ~/var/trac/0.12-stable repository list
Error: IOError: [Errno 13] Permission denied: u'/home/jun66j5/var/trac/0.12-stable/log/trac.log'

jun66j5@gotanda:777$ hg update -r trac-0.12.2
170 files updated, 0 files merged, 1 files removed, 0 files unresolved
jun66j5@gotanda:778$ make clean >/dev/null
jun66j5@gotanda:779$ PYTHONPATH=$PWD python2.4 trac/admin/console.py ~/var/trac/0.12-stable repository list
Error: Command not found

[Remy Blank]

Indeed, so this was a duplicate of #10044 (or the other way around). Thanks for testing!