Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#9568 closed enhancement (fixed)

Preferences -> Syntax Highlighting style selectbox should be binded to the keydown event too

Reported by: shesek Owned by: shesek
Priority: lowest Milestone: 0.12.1
Component: general Version:
Severity: trivial Keywords: ui, ux
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This is a tiny improvement, but it can make the interface for selecting the style much more convenient. The 'onchange' event doesn't fire until a select box losses focus, so one can't look at styles by scrolling them up/down with the keyboard, he has to choose them with the mouse, which is far less convenient.

This can be easily improved by biding to the 'onkeydown' event too, like that:

$("#pygment_theme").attr("autocomplete", "off").bind('change keydown',function() {
          switchStyleSheet(this.options[this.selectedIndex].text);
        });

Notice the .bind('change keydown',function(){ used instead of .change(function(){. This is the only modification needed.

I do realize this is very minor, but it could be a nice enhancement.

Attachments (0)

Change History (4)

comment:1 by Remy Blank, 14 years ago

Milestone: 0.13
Owner: set to Remy Blank

comment:2 by Remy Blank, 14 years ago

Milestone: 0.130.12.1
Resolution: fixed
Status: newclosed

Applied in [10017], except that I bound to keypress instead of keydown so that key repetitions also work.

comment:3 by Remy Blank, 14 years ago

Owner: changed from Remy Blank to shesek

comment:4 by shesek, 14 years ago

Great. thanks for taking the time to fix even such a minor issue :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain shesek.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from shesek to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.