add nowrap in some css

[wideweide@…]

I upgrade the trac to 0.12,now I can use my language — chinese,but a little trouble for css problem:

In report the word "edit" translate to "编辑",it display as

编
辑

I change the trac\htdocs\css\report.css

line 90 add — white-space: nowrap;

.tickets tbody td, .reports tbody td { padding: .1em .5em !important; white-space: nowrap;}

It will be ok.So please modify the source code to work fine

[anonymous]

all the table th perhaps need nowrap too,otherwise the "报表" displayed as

报
表

[anonymous]

trac.css : line 459

table.listing th { text-align: left; padding: 0 1em .1em 0; font-size: 12px ; white-space: nowrap;}

[Mikael Relbe]

I've seen the same problem for the swedish locale as well. I'll get back with a patch fixing this, in august, after a looong vacation :)

However, please add your findings here until then.

[Remy Blank]

Replying to mrelbe:

However, please add your findings here until then.

Hey Mikael, holidays are over! Where's that patch? :)

More seriously, we would need a patch pretty soon if this should be fixed in 0.12.1, otherwise please re-target to next-minor-0.12.x

[Mikael Relbe]

Replying to rblank:

Hey Mikael, holidays are over! Where's that patch? :)

No please, not yet :)

More seriously, we would need a patch pretty soon if this should be fixed in 0.12.1, otherwise please re-target to next-minor-0.12.x

Thanks for reminding me — I have been away for a very long time and feel totally out of the loop. Can you give me a couple of days/nights to recap?

[Remy Blank]

As this issue was my fault, I took the liberty to apply a fix in [10059] so that people would not get too annoyed about this still being in 0.12.1. I hope you don't mind.

[Mikael Relbe]

No worries, I'm sorry I didn't pay attention to this in due time…

[aprudnikov]

Please, add white-space: nowrap; also for table.listing thead th in trac.css for tables at all Admin\Ticket system\* pages.

In russian l10n unwanted line wrap appears:

[Remy Blank]

Fixed in [10112], thanks for the heads-up.

[Christian Boos]

+.tickets tbody td, .reports tbody td { padding: .1em .5em !important; white-space: nowrap; }

The above white-space: nowrap added in r10059 breaks the listing if View Description is turned on, as long paragraph lines in ticket descriptions will be forced to single line and will overflow (at least in Chrome and Firefox).

That particular change on td doesn't seem necessary to fix the present issue, ok to revert this line?

[Remy Blank]

Replying to cboos:

That particular change on td doesn't seem necessary to fix the present issue, ok to revert this line?

This looks indeed like a mistake, as I only remember working on the table headings. Yes, please revert.

[Remy Blank]

Reverted the line from comment:11 in [10229]. I'll leave the milestone at 0.12.1, as the original issue was fixed there.

[Jun Omae]

Action words are wrapped in report page for Japanese (r10505)

[Jun Omae]

In Japanese, the action words are wrapped in report page. The original issue maybe happens in Chinese, also.

trac/ticket/templates/report_list.html

@@ -29 +29 @@
           <tr py:when="reports" py:for="id, title, can_edit, can_delete in reports">
             <td class="report"><a title="View report" href="${href.report(id)}">{$id}</a></td>
             <td class="title"><a title="View report" href="${href.report(id)}">$title</a></td>
-            <td py:if="any_edit"><a py:if="can_edit" href="${href.report(id, action='edit')}"
+            <td class="action" py:if="any_edit"><a py:if="can_edit" href="${href.report(id, action='edit')}"
                                     title="Edit report">Edit</a></td>
-            <td py:if="any_delete"><a py:if="can_delete" href="${href.report(id, action='delete')}"
+            <td class="action" py:if="any_delete"><a py:if="can_delete" href="${href.report(id, action='delete')}"
                                       title="Delete report">Delete</a></td>
           </tr>
           <tr py:otherwise="">

trac/htdocs/css/report.css

@@ -84 +84 @@
 /* Styles for the report list and the report results table
    (extends the styles for "table.listing") */
 .reports td.title { width: 100%; white-space: normal; }
+.reports td.action { white-space: nowrap; }
 .tickets tbody:first-child tr.trac-group h2 { margin-top: 0; }
 .tickets tr.trac-group { border: none; }
 .tickets tr.trac-group:hover { background: none !important; }

[Remy Blank]

Heh, now at least I remember why I set the "nowrap" in the first place :)

Looks good to me. I suggest we still apply this for 0.12.2.

[Christian Boos]

Ok, with .reports in front, seems isolated enough to not risk breaking anything else.

[Jun Omae]

Applied in r10506. Thanks!