[PATCH] prevnext_nav() generates strange span element

[Jun Omae]

I found a strange span element of #ctxtnav in timeline page. The class attribute of span element has <a class="prev" href="/timeline?from=2010-05-24&amp;daysback=3&amp;authors=" title="Previous Period">Previous Period</a>.

      <div id="ctxtnav" class="nav">
        <h2>Context Navigation</h2>
          <ul>
              <li class="first"><span class="&lt;a class=&#34;prev&#34; href=&#34;/timeline?from=2010-05-24&amp;amp;daysback=3&amp;amp;authors=&#34; title=&#34;Previous Period&#34;&gt;Previous Period&lt;/a&gt;">&larr; <a class="prev" href="/timeline?from=2010-05-24&amp;daysback=3&amp;authors=" title="Previous Period">Previous Period</a></span></li><li class="last"><span class="missing">Next Period &rarr;</span></li>
          </ul>
        <hr />
      </div>

trac/web/chrome.py

@@ -171 +171 @@
                           class_='prev')
 
     add_ctxtnav(req, tag.span(Markup('← '), prev_link or prev_label,
-                              class_=prev_link or 'missing'))
+                              class_=not prev_link and 'missing' or None))
 
     if up_label and 'up' in links:
         up = links['up'][0]
@@ -183 +183 @@
                           class_='next')
 
     add_ctxtnav(req, tag.span(next_link or next_label, Markup(' →'),
-                              class_=next_link or 'missing'))
+                              class_=not next_link and 'missing' or None))
 
 
 def _save_messages(req, url, permanent):

[Remy Blank]

Good catch! Patch applied in [9792].