Edgewall Software
Modify ↓

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#9351 closed enhancement (fixed)

[PATCH] TracIni page should list default values

Reported by: anatoly techtonik <techtonik@…> Owned by: Mikael Relbe
Priority: normal Milestone: 1.0
Component: general Version: 0.11.7
Severity: normal Keywords: bitesized
Cc: lists@… Branch:
Release Notes:

TracIni page now shows the default value for each setting.

API Changes:
Internal Changes:

Description

​http://trac.edgewall.org/wiki/TracIni as well as ​http://trac.edgewall.org/about page doesn't list default values (unfortunately). The only way to get these values is to look at source code.

Attachments (2)

t9351_tracini-default-values-10198.patch​ (3.9 KB ) - added by Mikael Relbe 14 years ago.
#9351: Patch to apply on r10198
t9351_tracini-default-values-10198.2.patch​ (5.2 KB ) - added by Mikael Relbe 14 years ago.
Replaces former patch

Download all attachments as: .zip

Change History (11)

comment:1 by Remy Blank, 14 years ago

Keywords: bitesized added
Milestone: → unscheduled

Good idea.

comment:2 by Thijs Triemstra <lists@…>, 14 years ago

Cc: lists@… added

comment:3 by Mikael Relbe, 14 years ago

Milestone: unscheduled → 0.13
Owner: set to Mikael Relbe
Summary: TracIni page should list default values → [PATCH] TracIni page should list default values

A third column is added in the output from [[TracIni]] macro, containing the default value. The text "(no default)" is presented in case no default values is set.

Spaces were inserted to the in-built list options in Trac to restrict the width of the new column for these at least. 

[trac]
mainnav = wiki,timeline,roadmap,...

is changed to 

[trac]
mainnav = wiki, timeline, roadmap, ...

by Mikael Relbe, 14 years ago

Attachment: t9351_tracini-default-values-10198.patch​ added

#9351: Patch to apply on r10198

comment:4 by Christian Boos, 14 years ago

Owner: changed from Mikael Relbe to Christian Boos
Status: new → assigned

Fine for me (accepting so that I remember it's ready to commit).

I'd prefer to have 85% for div.tracini td.nodefault as I find 80% a bit too small, but that's largely cosmetic and perhaps browser dependent even.

in reply to:  4 comment:5 by Mikael Relbe, 14 years ago

Replying to cboos:

I'd prefer to have 85% for div.tracini td.nodefault

That's perfectly fine with me. (80% was an influence by div.trac-modifiedby)

comment:6 by Mikael Relbe, 14 years ago

Oh, just discovered yet a couple of default values that needed comma-space separations… Replacing the patch with a new one.

by Mikael Relbe, 14 years ago

Attachment: t9351_tracini-default-values-10198.2.patch​ added

Replaces former patch

comment:7 by Christian Boos, 14 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Thanks, tested and applied in r10213, tweaked in r10214 ;-)

comment:8 by Christian Boos, 14 years ago

Owner: changed from Christian Boos to Mikael Relbe

comment:9 by anatoly techtonik <techtonik@…>, 14 years ago

Great. Thanks for patch.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Mikael Relbe.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mikael Relbe to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.