Invalid relative path on TracGuideToc.py when invoked from the start page

[Juanma Barranquero]

I've copied TracGuideToc.py for a Contents menu on my own installation. However, if you call it from the main WikiStart page and you've invoked it with

http://localhost/wiki

instead of

http://localhost/wiki/trac

the relative locations for the TOC items are wrong (they refer to http://localhost/trac/MyPage instead of http://localhost/trac/wiki/MyPage. This is not going to fail on the Trac Project site because the TOC is never invoked from WikiStart, but still it'd be better to patch the macro:

trac/wikimacros/TracGuideToc.py

@@ -35 +35 @@
             cls = ''
-        html += '<li %s><a href="%s">%s</a></li>' % (cls, ref, title)
+        html += '<li %s><a href="/trac/wiki/%s">%s</a></li>' % (cls, ref, title)
     return html + '</ul></div>'

[Christopher Lenz]

We cannot rely on Trac running under the path /trac, so this patch won't work. However, we should be able to use Href.py to get links that work in any situation.

Let's fix this for 0.8.

[Christopher Lenz]

Should be fixed in [1062].

[Juanma Barranquero]

Nice, I didn't know about Href.py (obviously). I'll try to be more careful (use the Source, Luke!).

[Juanma Barranquero]

Oh, another comment: TracGuide.py is included in 0.8, but the updated Wiki pages that use it don't (nor are they updated in the trunk).

[Christopher Lenz]

They'll be updated directly before the final release.