[Patch] Nothing happens by clicking on foldable elements

[Jun Omae]

The cursor on foldable elements excluding the anchor is "pointer" and seems clickable. However nothing happens by clicking.

It should that it's clickable. attachment:folding.diff​.

[Christian Boos]

I'm afraid you have to be a bit more precise about the error.

The Attachments foldable section on Wiki pages works both here on t.e.o (e.g. MacroBazaar#no1) and in all my test instances…

[Remy Blank]

I noticed that, too. If you click on the word "Attachments", the attachments section unfolds. But if you click on the white space right of the word, the cursor still shows a hand, but if you click, nothing happens.

This is cosmetic, so we can do that after 0.12.

[Christian Boos]

Ah, understood. But then, for the fix I'd suggest that we move the .css("cursor", "pointer") to the <a> element only.

[Remy Blank]

That's what I would have suggested, too.

[Jun Omae]

That's OK. The default cursor of anchors is "pointer", we should remove .css("cursor", "pointer")…

trac/htdocs/js/folding.js

@@ -23 +23 @@
       if (autofold && (count != fragId))
         trigger.parents().eq(1).addClass("collapsed");
       count++;
-    }).css("cursor", "pointer");
+    });
   }
 
   /** Enable columns of a table to be hidden by clicking on the column header.

[Remy Blank]

Replying to jomae:

That's OK. The default cursor of anchors is "pointer", we should remove .css("cursor", "pointer")…

Indeed, that works fine. Applied in [10001].