custom query URLs don't respect ''after'' condition

[Christian Boos]

I noticed that the following link won't work as expected:

query:?milestone=next-major-0.1X&changetime=;05/01/10

The "after" field is left blank (should contain 05/01/10).

The reverse query works:

query:"?milestone=next-major-0.1X&changetime=05/01/10;"

But:

query:?milestone=next-major-0.1X&changetime=05/01/10;05/05/10

only sets the "before" field, the "after" is also left blank.

We would need that link to work on t.e.o (present in milestone:next-major-0.1X description).

[Remy Blank]

I'll have a look tomorrow.

[Remy Blank]

Funny, it works if you escape the ;…

• query:?milestone=next-major-0.1X&changetime=%3B05/01/10
• query:"?milestone=next-major-0.1X&changetime=05/01/10%3B"
• query:?milestone=next-major-0.1X&changetime=05/01/10%3B05/05/10

[Remy Blank]

Bad… The ; character is interpreted the same as & by urlparse.parse_qsl() (as an argument separator), which is used by cgi.FieldStorage. This is confirmed by ​Wikipedia. So the following URL:

/query?milestone=next-major-0.1X&changetime=;05/01/10

results in the following query arguments:

args = [('milestone', 'next-major-0.1X'), ('changetime', ''), ('05/01/10', '')]

It seems that the choice of ; as a date separator was… unwise. Time to change it to '|', I guess…

[Christian Boos]

or ..?

• 05/01/10..05/05/10
• ..05/05/10
• 05/01/10..

[Remy Blank]

'|' is a bad choice as well, as it triggers the automatic separation into several arguments. I have a patch ready that uses '@', but I like your '..' better :)

[Remy Blank]

Separator changed to '..' in [9637], and documentation updated in TracQuery@26.

[Christian Boos]

t.e.o updated, queries on milestone:next-major-0.1X now work as they should, thanks a lot!