Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9303 closed defect (fixed)

custom query URLs don't respect ''after'' condition

Reported by: Christian Boos Owned by: Remy Blank
Priority: normal Milestone: 0.12
Component: report system Version: 0.12b1
Severity: normal Keywords: query date
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Christian Boos)

I noticed that the following link won't work as expected:

query:?milestone=next-major-0.1X&changetime=;05/01/10

The "after" field is left blank (should contain 05/01/10).

The reverse query works:

query:"?milestone=next-major-0.1X&changetime=05/01/10;"

But:

query:?milestone=next-major-0.1X&changetime=05/01/10;05/05/10

only sets the "before" field, the "after" is also left blank.

We would need that link to work on t.e.o (present in milestone:next-major-0.1X description).

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 9 years ago

Description: modified (diff)

comment:2 by Remy Blank, 9 years ago

Owner: set to Remy Blank

I'll have a look tomorrow.

comment:4 by Remy Blank, 9 years ago

Bad… The ; character is interpreted the same as & by urlparse.parse_qsl() (as an argument separator), which is used by cgi.FieldStorage. This is confirmed by Wikipedia. So the following URL:

/query?milestone=next-major-0.1X&changetime=;05/01/10

results in the following query arguments:

args = [('milestone', 'next-major-0.1X'), ('changetime', ''), ('05/01/10', '')]

It seems that the choice of ; as a date separator was… unwise. Time to change it to '|', I guess…

comment:5 by Christian Boos, 9 years ago

or ..?

  • 05/01/10..05/05/10
  • ..05/05/10
  • 05/01/10..

comment:6 by Remy Blank, 9 years ago

'|' is a bad choice as well, as it triggers the automatic separation into several arguments. I have a patch ready that uses '@', but I like your '..' better :)

comment:7 by Remy Blank, 9 years ago

Resolution: fixed
Status: newclosed

Separator changed to '..' in [9637], and documentation updated in TracQuery@26.

comment:8 by Christian Boos, 9 years ago

t.e.o updated, queries on milestone:next-major-0.1X now work as they should, thanks a lot!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.