Adding field data to ticket diff data

[Mitar]

I would like to request that field given to version_info in ticket displaying​ would be added to returned data (and thus data used for displaying ticket diff changes). Because otherwise it is very hard (and impossible to do it nicely) to determine for what a diff in changes list is for, when you want to post-process data in post_process_request.

So simply adding field would be it:

return {'path': path, 'rev': rev, 'shortrev': shortrev,
        'href': get_resource_url(self.env, t, req.href),
        'field': field}

[Remy Blank]

Your suggestion duplicates the field name in both change.old and change.new. How about this instead? It also adds the field name for non-text fields.

trac/ticket/web_ui.py

@@ -812 +812 @@
                 old, new = old_ticket[k], new_ticket[k]
                 if old != new:
                     label = field_labels.get(k, k.capitalize())
-                    prop = {'name': label,
+                    prop = {'name': label, 'field': k,
                             'old': {'name': label, 'value': old},
                             'new': {'name': label, 'value': new}}
                     rendered = self._render_property_diff(req, ticket, k,
@@ -845 +845 @@
                                 ignore_case='-i' in diff_options,
                                 ignore_space_changes='-b' in diff_options)
 
-            changes.append({'diffs': diffs, 'props': [],
+            changes.append({'diffs': diffs, 'props': [], 'field': field,
                             'new': version_info(tnew, field),
                             'old': version_info(told, field)})
 

[Mitar]

Sounds great.

[Remy Blank]

Patch applied in [9622].