#9269 closed enhancement (fixed)
[PATCH] Jumping site-header
| Reported by: | Mikael Relbe | Owned by: | Mikael Relbe |
|---|---|---|---|
| Priority: | highest | Milestone: | 0.12 |
| Component: | rendering | Version: | 0.12dev |
| Severity: | trivial | Keywords: | css |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Problem appears when not using a logo for a site, but just a header: The site header jumps around when switching between Browse Source and other functions (Wiki, Tickets, etc). The problem is that "trunk/trac/htdocs/css/browser.css" defines padding for "h1", which is inherited by "#header h1" since it lacks padding definition.
(Yes Christian, this is the same that I mailed you directly, I was thinking it would be easier to get fixed via a ticket after all.)
Attachments (1)
Change History (8)
by , 16 years ago
| Attachment: | minor-css-correction_trunk-9478.patch added |
|---|
comment:1 by , 16 years ago
| Summary: | Jumping site-header → [Patch] Jumping site-header |
|---|
comment:3 by , 16 years ago
| Owner: | set to |
|---|---|
| Priority: | normal → highest |
| Severity: | normal → trivial |
| Summary: | [Patch] Jumping site-header → [PATCH] Jumping site-header |
This tiny patch is ready for being merged with trunk.
comment:4 by , 16 years ago
Please just show me how to reproduce this (no logo for a site, but just a header) easily ;-)
comment:5 by , 16 years ago
Create a new site having no logo but showing a project name in trac.ini:
[header_logo] ;alt = (please configure the [header_logo] section in trac.ini) ;height = -1 ;link = src = ;width = -1 [project] name = Example Project
"Example Project" should now be shown instead of the non-existing icon, which jumps around when you switch between Browse Source and other resources.
comment:6 by , 16 years ago
| Milestone: | 0.12.1 → 0.12 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
At long last… problem reproduced, fix tested and patch applied in [9654]. Thanks!
I actually never realized you have the project's name shown as a heading when you don't have a logo configured ;-)
comment:7 by , 16 years ago
| Owner: | changed from to |
|---|
This patch fixes the problem