Edgewall Software
Modify

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#9254 closed defect (fixed)

SQL report realm/id decoration

Reported by: mpotter@… Owned by: Jun Omae
Priority: normal Milestone: 0.12.3
Component: report system Version: 0.11.7
Severity: normal Keywords: bitesized
Cc: Jun Omae Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When one uses the realm with the id feature of the SQL report system (Automatically formatted columns), the decoration applied to the id value is incorrect. The id column value is always decorated with a #, implying that it is a ticket link.

Suggestion:

For Realm Decorate With Example
ticket (default) # #1
report {} or report: {15} or report:15
wiki nothing or wiki: WikiStart or wiki:WikiStart
changeset [ ] or changeset: [1/trunk] or changeset:1/trunk
milestone milestone: milestone:1.0

Hmm, I don't actually know all the realms supported, and don't see them documented anywhere.

Attachments (1)

t9254-realm-decoration-r10863.diff (9.2 KB ) - added by Jun Omae 11 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Christian Boos, 12 years ago

Keywords: bitesized added
Milestone: next-minor-0.12.x

Should be a simple matter of calling get_resource_shortname() at the right place, assuming the realm column has been defined.

comment:2 by mpotter@…, 12 years ago

Version: 0.11.60.11.7

0.11.7 was not available with filed.

comment:3 by Jun Omae, 11 years ago

Cc: Jun Omae added

I've worked the issue in my branch, diff:jomae@7819:7820. Thoughts?

comment:4 by Christian Boos, 11 years ago

Looks great!

comment:5 by Remy Blank, 11 years ago

Changeset and source resources are always required to have a parent resource, the repository to which they belong. This assumption is present in many parts of the code. I see how this prevents creating reports about such resources. Instead of allowing parent-less resources like you do in the patch, we should rather add a way to specify the parent resource in reports, something like parent_realm and parent_id columns. This will also allow creating reports in the multi-repository scenario.

comment:6 by Jun Omae, 11 years ago

Thanks for the comments.

I reworked t9254-realm-decoration-r10863.diff, adds support for parent_realm and parent_id columns in a report. It would be able to link to a file in multi-repository and a attachment of wiki.

Related to #10061.

by Jun Omae, 11 years ago

comment:7 by Remy Blank, 11 years ago

Looks good!

comment:8 by Jun Omae, 11 years ago

Milestone: next-minor-0.12.x0.12.3
Resolution: fixed
Status: newclosed

The patch is applied in [10867].

comment:9 by Jun Omae, 11 years ago

Owner: set to Jun Omae

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.