SQL report realm/id decoration

[mpotter@…]

When one uses the realm with the id feature of the SQL report system (Automatically formatted columns), the decoration applied to the id value is incorrect. The id column value is always decorated with a #, implying that it is a ticket link.

Suggestion:

For Realm	Decorate With	Example
ticket (default)	#	#1
report	{} or report:	{15} or report:15
wiki	nothing or wiki:	WikiStart or wiki:WikiStart
changeset	[ ] or changeset:	[1/trunk] or changeset:1/trunk
milestone	milestone:	milestone:1.0

Hmm, I don't actually know all the realms supported, and don't see them documented anywhere.

[Christian Boos]

Should be a simple matter of calling get_resource_shortname() at the right place, assuming the realm column has been defined.

[mpotter@…]

0.11.7 was not available with filed.

[Jun Omae]

I've worked the issue in my branch, diff:jomae@7819:7820. Thoughts?

[Christian Boos]

Looks great!

[Remy Blank]

Changeset and source resources are always required to have a parent resource, the repository to which they belong. This assumption is present in many parts of the code. I see how this prevents creating reports about such resources. Instead of allowing parent-less resources like you do in the patch, we should rather add a way to specify the parent resource in reports, something like parent_realm and parent_id columns. This will also allow creating reports in the multi-repository scenario.

[Jun Omae]

Thanks for the comments.

I reworked t9254-realm-decoration-r10863.diff​, adds support for parent_realm and parent_id columns in a report. It would be able to link to a file in multi-repository and a attachment of wiki.

Related to #10061.

[Remy Blank]

Looks good!

[Jun Omae]

The patch is applied in [10867].