In the ticket change history list, comment div's are printed even with empty comments.

[eino.saarela.rossi@…]

The ticket change history list contain following div-tag on each change event even with empty comment.

<div class="comment searchable"> </div>

It is an issue when using different background color or border for the comment fields.

I've fixed this issue like this in the trac/ticket/templates/ticket.html file

76c76
<       <div py:if="'comment' in change" class="comment searchable" xml:space="preserve">
---
>       <div py:if="change.comment" class="comment searchable" xml:space="preserve">

[Christian Boos]

… or even change.get('comment').

[Ryan J Ollos]

On 1.4-stable there is no empty div tag if the comment is empty: tags/trac-1.4.1/trac/ticket/templates/ticket_change.html@:205-208#L192​.

A comment consisting of only ZWSP is allowed. We should treat it the same as a comment containing only whitespace.

trac/ticket/model.py

@@ -28 +28 @@
 from trac.util import as_int, embedded_numbers, to_list
 from trac.util.datefmt import (datetime_now, from_utimestamp, parse_date,
                                to_utimestamp, utc, utcmax)
-from trac.util.text import empty
+from trac.util.text import empty, stripws
 from trac.util.translation import _, N_, gettext
 
 __all__ = ['Ticket', 'Type', 'Status', 'Resolution', 'Priority', 'Severity',
@@ -349 +349 @@
 
         props_unchanged = all(self.values.get(k) == v
                               for k, v in self._old.iteritems())
-        if (not comment or not comment.strip()) and props_unchanged:
+        if (not comment or not stripws(comment)) and props_unchanged:
             return False  # Not modified
 
         if when is None:

[Ryan J Ollos]

Added test coverage: [d426df83a/rjollos.git].

[Ryan J Ollos]

Committed to 1.4-stable in r17347, merged to trunk in r17348.

[Ryan J Ollos]

This change hasn't been deployed yet to t.e.o, but we had a comment on ticket #130 that is empty. I queried the database and it appears to be an empty string, no invisible chars such as ZWSP. There seems to still be a way to post an empty comment: branches/1.4-stable/trac/ticket/model.py@17347:350-353#L339​.