Plugin admin PostgreSQLConnector

[Benn]

Vanish web control(select, "+", and more..) when mouse click "+" of PostgreSQLConnector

[Remy Blank]

Could you please describe the issue in more detail, and give us some context? I'm unfortunately unable to understand what and where the problem is, and how to reproduce it.

[Benn]

I was momentarily under the illusion that it was hidden in frame layer.

[Christian Boos]

Well, I think it's a real problem.

The general layout issue we have with the admin panels (#8866) is again at work here.

Before expansion:

After clicking on the [+]:

As the list of trac.* component is long, it's too easy to miss the horizontal scrollbar.

Besides, allowing the currently in use connector component to be deselected makes it really easy to shoot yourself in the foot ;-)

[Christian Boos]

admin_plugins.html before expansion

[Christian Boos]

admin_plugins.html after expansion of a description containing a wiki pre block

[Christian Boos]

Plugin admin: the currently selected db connector becomes a required component.

[Christian Boos]

Plugin admin: the currently selected db connector becomes a required component (take 2: remove spurious required=True in sqlite connector constructor and add an extra clean-up)

[Remy Blank]

Ok, thanks for the explanation. The horizontal scrollbar is a known issue (comment:12:ticket:8866) but we currently don't have a solution for that. The previous behavior was even worse (fixed in comment:7:ticket:8291). I know Christian did a few tests, but I can't find the ticket where he reported the results ATM.

I like the idea of marking required components as you did, and to make the database connector required, so I'll apply that patch shortly. Thanks!

[Remy Blank]

Oops, sorry Christian, I didn't notice you were the author of the comments above :)

So yes, nice patch, please apply. About the layout, I still don't have a better idea.

[Christian Boos]

Replying to rblank:

nice patch, please apply.

r9458

About the layout, I still don't have a better idea.

One step, specific to the problem reported here, would be to have the expand/collapse buttons at the left (using the traditional triangle icons).

[Remy Blank]

Replying to cboos:

r9458

I'm a bit surprised that you used a try: except: block here. Isn't your style more like:

c = component 
if c in env and not issubclass(c, env.__class__):
    c = component(env)
required = getattr(c, 'required', False)

[Christian Boos]

Good point ;-) This try/except survived from an intermediate stage, there's no justification for it anymore. And I didn't even think about the 3 arguments form, which indeed leads to simpler code. Updated in r9459.

[Remy Blank]

Replying to cboos:

One step, specific to the problem reported here, would be to have the expand/collapse buttons at the left (using the traditional triangle icons).

Done in [10018].