Modify ↓
#9182 closed enhancement (fixed)
[PATCH] Support margin-* in ImageMacro
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | wiki system | Version: | 0.12dev |
| Severity: | normal | Keywords: | imagemacro |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
This is a follow-on to #5223 requesting better control over layout through the ImageMacro. As part of the resolution, r8093 added support for the 'margin' style (symmetric margins only). It would be exceedingly helpful to support asymmetric margins (e.g. for images floated to the left you only want to set a margin on the right and bottom — the current solution with symmetric margins causes the images to be indented and increases the inter-paragraph spacing when the image starts off a paragraph).
I recognize parsing the full multi-value margin key is probably too complex. Instead, the attached patch (against /trunk r9406) adds support for margin-left, margin-right, margin-top, and margin-bottom.
Attachments (1)
Change History (4)
by , 15 years ago
| Attachment: | trac-wiki-macros_margin.patch added |
|---|
comment:1 by , 15 years ago
| Keywords: | imagemacro added |
|---|---|
| Milestone: | → 0.12 |
Looks good! Thanks for the patch.
comment:3 by , 15 years ago
| Owner: | set to |
|---|
Note:
See TracTickets
for help on using tickets.
patch against /trunk r9406 adding margin-* support