[PATCH] Patch and plugin for creating comments and ticket-changes which are only visible for a choosable group

[michael.henke@…]

Hi there,

as described in the subject I made a modification which allows users to create hideable comments. The problem is now, that I don't know how to distribute it.

The modification makes changes to the ticket-system and is delivered with a plugin which checks the permissions of the requesting user.

The question I have now: Could you integrate the modification into trac? Or should I make a Trac Hacks page with a notice that the modifcation changes the core-files?

Looking forward to hearing from you,

Michael

[michael.henke@…]

the plugin, a patchfile and a sql script

[Remy Blank]

There are two reasons why I don't want to integrate this patch:

• It adds a new column to the ticket table. Adding more columns to that table for every new feature makes the code difficult to maintain. If anything, you should consider using a custom ticket field instead, it would probably simplify your code substantially.
• I'm pretty sure this functionality can be implemented with a stream filter.

Considering this, you should be able to implement the complete functionality in a plugin, without having to patch Trac core. You may find this to be much easier to maintain in the long run, too. And trac-hacks is certainly a good location to host the plugin.

See trunk/tracopt/ticket/deleter.py​ for an example component that uses a stream filter (ITemplateStreamFilter) to alter the ticket page.

[michael.henke@…]

Hi!

On your advice I started to write the modifcation as a Plugin. But now I have a problem with the filter_stream implementation.

First a little bit code:

buffer = StreamBuffer()

def check_comment():
		print buffer
		return buffer

#'//form[@method="get" and @action="#comment" and @class="printableform"]'
html = stream | Transformer('//div[@class="change"]') \
		.copy(buffer,False) \
		.replace(check_comment()).end()
		
		#.select('//div[@class="change"]') \
		#.copy(buffer,True).end() \
		
return html

As you can see I select the ticket changes with the Transformer. In the function check_comment() I want to check if the current user is able to see the comment.

The problem is, that I can't access the buffer in the check_access function. Why can't I access the Streambuffer "buffer" in the check_access() method?

bye, Michael