patch renderer should handle added binary files in GIT binary diffs

[Christian Boos]

2010-03-15 22:05:19,147 Trac[api] WARNING: HTML preview using <trac.mimeview.patch.PatchRenderer object at 0x2693850> failed (
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/trac/mimeview/api.py", line 759, in render
    rendered_content, filename, url)
  File "build/bdist.linux-x86_64/egg/trac/mimeview/patch.py", line 51, in render
    Mimeview(self.env).tab_width)
  File "build/bdist.linux-x86_64/egg/trac/mimeview/patch.py", line 118, in _diff_to_hdf
    oldrev, newrev = index_line.split()[-1].split('..')
ValueError: need more than 1 value to unpack)

for attachment:8216-textarea-resize-r8859.patch:ticket:8721​.

This is an issue with GIT binary diffs: for a new binary there's a new file mode 100644 line, which is not currently expected by the code.

94	diff --git a/trac/htdocs/grip.png b/trac/htdocs/grip.png
95	new file mode 100644
96	index 0000000000000000000000000000000000000000..6524d4167d2d6e3939cfcf3111ce520acd66bc21
97	GIT binary patch
98	literal 162
99	zc%17D@N?(olHy`uVBq!ia0vp^(m>40!3-puuch|@DVB6cUq=Rp^(V|(yIunMk|nMY
100	zCBgY=CFO}lsSJ)O`AMk?p1FzXsX?iUDV2pMQ*D5X*aCb)TzBu@{r~^}iVZzqfg(&L
101	zL4Lvi8J=!8@B;EgJY5_^DsCku9AK6xWM-3k!OUU6z#qV1KKathOF(%BPgg&ebxsLQ
102	E0Ke)mAOHXW
103	

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed