Edgewall Software
Modify

Opened 13 years ago

Last modified 7 years ago

#9125 new enhancement

Report rendering needs some general overhaul

Reported by: Carsten Klein <carsten.klein@…> Owned by:
Priority: low Milestone: next-major-releases
Component: report system Version: 0.12dev
Severity: normal Keywords: patch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When using column_ for breaking the row after the column, everything works fine except that the column has no colspan assigned to extend it across the columns left available to the right.

E.g.

select id, summary as summary_, component, milestone from ticket…

will render both the id and the summary in one line and the rest in the following line.

However, the summary column will only be one column wide whereas it should extend across the available N-1 columns to the right.

Attachments (2)

report_patch.diff (8.0 KB ) - added by Carsten Klein <carsten.klein@…> 13 years ago.
patch to both report.py and templates/report_view.py
9125.patch (2.1 KB ) - added by Carsten Klein <carsten.klein@…> 13 years ago.
revised patch to report.py

Download all attachments as: .zip

Change History (12)

comment:1 by Remy Blank, 13 years ago

Resolution: worksforme
Status: newclosed

The {row}_ syntax only introduces a line break, not a full line. You're probably looking for the _{row}_ syntax instead. Try:

select id, component, milestone, summary as _summary_ from ticket...

See TracReports for more details.

comment:2 by carsten.klein@…, 13 years ago

Priority: normallow
Resolution: worksforme
Status: closedreopened
Type: defectenhancement

I sure know that it is working, but it would be nicer to have it extend across the remaining columns.

I am currently looking into a patch that would remedy the situation, however, it renders quite complicated to make it work (hidden columns etc.).

I will reopen this as a enhancement request and put it on low.

by Carsten Klein <carsten.klein@…>, 13 years ago

Attachment: report_patch.diff added

patch to both report.py and templates/report_view.py

comment:3 by Carsten Klein <carsten.klein@…>, 13 years ago

the presented patch remedies the situation that

  • under certain conditions empty table rows are being rendered (e.g. id as _ticket_ as the second column after … as color or inbetween)
  • all columns that are considered fullrows will now extend not to a standard of 100 columns but to the actual number of available (visible) columns
  • all columns that cause a row break will now also extend across the remainder of the columns to the right
  • each row in a row_group will be in a separate table body (discussable)

all in all this should provide for nicer renderings of ticket reports

in reply to:  3 comment:4 by Carsten Klein <carsten.klein@…>, 13 years ago

Replying to Carsten Klein <carsten.klein@…>:

additionally

  • outcommented the <hr> in case of a fullrow
  • fullrow cells will now have the correct class name, e.g. summary and not fullrow

comment:5 by Remy Blank, 13 years ago

Keywords: patch added
Milestone: next-minor-0.12.x

Thanks for the patch.

comment:6 by Carsten Klein <carsten.klein@…>, 13 years ago

Summary: Using as column_ to break the row after the column does not colspan the columnReport rendering needs some general overhaul

by Carsten Klein <carsten.klein@…>, 13 years ago

Attachment: 9125.patch added

revised patch to report.py

comment:7 by Carsten Klein <carsten.klein@…>, 13 years ago

the previous patch to report.py rendered the view unusable (i.e. it missed inclusion of ticket id when id was rendered as a fullrow, e.g. id as _ticket_),

comment:8 by Carsten Klein <carsten.klein@…>, 13 years ago

possible regression here still: user does not include ticket.id in query

result would be that all tickets in the report will not be navigateable.

perhaps we should introduce the ticket id as a mandatory requirement for reports?

comment:9 by Christian Boos, 12 years ago

Milestone: next-minor-0.12.xnext-major-0.1X

comment:10 by Ryan J Ollos, 7 years ago

Status: reopenednew

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.