Edgewall Software
Modify

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#9034 closed defect (worksforme)

Spaces in URI's are incorrectly parsed

Reported by: jbergstroem Owned by:
Priority: normal Milestone:
Component: web frontend Version: 0.12dev
Severity: major Keywords: nginx fcgi uri space needinfo
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

First off, this probably related to #8128, but my deployment differ which inclined me to create a new ticket instead of reopening the old one.

Milestones, attachments, folders in browsing and most other things referring to uri's with spaces in them are incorrectly parsed mostly in resulting "X Y Z does not exist".

My deployment looks like this: nginx → fastcgi → fcgi_frontend.py started by spawn-fcgi.

I've been running the multirepos branch for 6-8 months. I started seeing this some months ago but disregarded it (workarounds are not naming your stuff in such a manner), kind of "hoping" it would disappear when merging back to trunk.

By looking at r7953 i hotpatched source:trunk/trac/web/main.py:#L369 and wrapping path_info in urllib.urldecode. That made trac accept the urls, but unfortunately not treating them correctly, for instance: clicking "Milestone 123" resulted in editing a new milestone called "Milestone%20123"

I'm currently running Trac 0.12dev-r9153. Other software is Python 2.6.4, Spawn-fcgi 0.6.3 and nginx 0.8.33.

Attachments (0)

Change History (5)

comment:1 by Christian Boos, 14 years ago

Keywords: nginx fcgi added
Milestone: not applicable

Perhaps not an InstallationIssue, but quite installation specific anyway.

Problem is, apparently no Trac developers (a rare species) uses this kind of setup, so you're on your own here. Don't forget to share the solution if you find it…

comment:2 by jbergstroem, 14 years ago

I'll try switching nginx with lighttpd and see what happens.

comment:3 by Christian Boos, 14 years ago

Keywords: needinfo added

comment:4 by anonymous, 14 years ago

Resolution: fixed
Status: newclosed

Some hundred revisions later on the same setup it now works.

comment:5 by Remy Blank, 14 years ago

Milestone: not applicable
Resolution: fixedworksforme

I don't think we actually did anything to fix this, so I'm changing the resolution accordingly.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.