trac.ini file:inhert config values only correct with first file

[Shane Caraveo <shanec@…>]

I hit a problem where values in the inherited files are only correct for the first file in the list. For the second file, the default value from the option registry gets used

I am using the multiple parent config file feature with something like:

[inherit] file = c.ini, d.ini

In d.ini I have:

[project] footer = my sitewide footer

My ini file sturcture looks like:

a.ini → b.ini → c.ini,d.ini

• a.ini is the projects ini file, it inherits b.ini
• b.ini is a generated file, and we occasionally overwrite this on updates.
• c and d contain data that can get changed (via custom admin panels) and are meant to affect all projects in a multi project system.

The implementation of trac.config.section.get fails to actually use the value from d.ini, because it got the default value from the registry when it looked at c.ini.

I'll attach a patch, it's not the most optimal patch but illustrates a fix.

[Shane Caraveo <shanec@…>]

One issue with the patch, if you have:

[inherit] file = a,b,c

And a value is defined in more than one of the files, the first from the list will be used. What precedence happens in that situation should be documented (admittedly haven't looked to see if it is).

[Remy Blank]

I'll have a look at this.

[Remy Blank]

Confirmed, thanks for the bug report. Could you please try this slightly simpler patch?

trac/config.py

@@ -345 +345 @@
                 if value is not _use_default:
                     break
             else:
-                option = Option.registry.get((self.name, key))
-                value = option and option.default or _use_default
+                if default is not _use_default:
+                    option = Option.registry.get((self.name, key))
+                    value = option and option.default or _use_default
+                else:
+                    value = _use_default
         if value is _use_default:
             return default
         if not value:

[Remy Blank]

Patch applied in [9115], together with a test case.