[PATCH] trac-admin hotcopy should export database dump for non-sqlite projects

[Thijs Triemstra]

Would be nice to have a mysql/postgress db dump when using trac-admin ENV hotcopy DEST. We already have all the necessary functionality, as we do a backup during upgrades. We could store the dump in the ENV/db directory before the copy operation.

From #8952

[Christian Boos]

PatchWelcomed.

[anonymous]

Agreed, this would be rad!

[Thijs Triemstra]

against 0.12-stable r10370

[Thijs Triemstra]

The attached patch creates a 'db-backup.sql' in the environment folder which get copied in the hotcopy destination folder. MySQL trac installations don't have a db folder so I copied it to the root of the environment. Maybe a db folder for non-sqlite backups should be made when using hotcopy that can hold the .sql file?

[Remy Blank]

A db folder even for non-SQLite backends would make sense, yes. However, shouldn't the dump rather be placed into a db folder of the destination instead of the source, probably after the copytree() call? That would avoid having a possibly large file (the dump of t.e.o is over 2 GB) placed twice in the filesystem.

[Thijs Triemstra]

Replying to rblank:

A db folder even for non-SQLite backends would make sense, yes. However, shouldn't the dump rather be placed into a db folder of the destination instead of the source, probably after the copytree() call? That would avoid having a possibly large file (the dump of t.e.o is over 2 GB) placed twice in the filesystem.

The attached patch creates a db folder where the sql dump is created. I was wondering if a cmdline option like --no-database (to exclude the db export for hotcopy) or --database (to include the db export for hotcopy)? With 2GB databases the user might want to skip the export db option?

[Remy Blank]

Replying to thijstriemstra:

I was wondering if a cmdline option like --no-database (to exclude the db export for hotcopy) or --database (to include the db export for hotcopy)? With 2GB databases the user might want to skip the export db option?

That's a good idea indeed. Probably --no-database, so that it's included by default.

[Thijs Triemstra]

Replying to rblank:

That's a good idea indeed. Probably --no-database, so that it's included by default.

Sounds good. I guess a status message (Exporting database…) might be useful as well, I reckon it takes quite a while to export a 2GB db, and without such a message users might think hotcopy crashed or died.

[Thijs Triemstra]

The attached patch adds the ability to ignore the database export (inc sqlite) using the --no-database or -d flag. For example:

trac-admin ../test2 hotcopy ../testerr/
Hotcopying /Users/thijstriemstra/Sites/projects/opensource/test2 to ../testerr/ ...
Exporting database...
Hotcopy done.

Without database:

trac-admin ../test2 hotcopy ../testerr/ --no-database
Hotcopying /Users/thijstriemstra/Sites/projects/opensource/test2 to ../testerr/ ...
Hotcopy done.

[Remy Blank]

Patch applied in [10387] with very minor changes:

• DatabaseManager.backup() already creates the destination directory if it doesn't exist, so there's no need to do it in _do_hotcopy().
• For SQLite, exclude only the database file if --no-database is specified, not the complete db directory, as it could contain other files (e.g. backups from upgrades).
• Removed the short form of the --no-database option.

Thanks for your great work!