[PATCH] Send Notification Email with local timezone

[hwyss@…]

Currently, Trac sends out notifications with an UTC Date header. I would like to see my server's local timezone (patch attached) or even better the users' configured timezone.

Related: ​http://trac.edgewall.org/changeset/1512

[Remy Blank]

This is related to #2182.

[Christian Boos]

For user configured timezone, this is tricky, we would need to send "personalized" mails (same problematic than for translated notification mails).

For using server's local timezone instead of UTC, well, I think it all depends what kind of Trac it is (public project on the internet vs. "in house"), so maybe a setting would make sense here…

(Improved) PatchWelcome ;-)

[Thijs Triemstra <lists@…>]

Replying to cboos:

For using server's local timezone instead of UTC, well, I think it all depends what kind of Trac it is (public project on the internet vs. "in house"), so maybe a setting would make sense here…

What about using the default_timezone setting (for now)?

[Remy Blank]

Replying to Thijs Triemstra <lists@…>:

What about using the default_timezone setting (for now)?

Sounds like a good idea to me.

[Thijs Triemstra]

With the original patch, updated for 0.12-stable, I get:

Date: Tue, 07 Dec 2010 17:22:06 +0100

trac/notification.py

@@ -456 +456 @@
                 headers['To'] = ', '.join(toaddrs)
         if pcc:
             headers['Cc'] = ', '.join(pcc)
-        headers['Date'] = formatdate()
+        headers['Date'] = formatdate(localtime=True)
         msg = MIMEText(body, 'plain')
         # Message class computes the wrong type from MIMEText constructor,
         # which does not take a Charset object as initializer. Reset the

Which is correct but it's a local trac instance so duh. Without the patch I get:

Date: Tue, 07 Dec 2010 16:24:31 -0000

This patch checks for that default_timezone setting:

trac/notification.py

@@ -456 +456 @@
                 headers['To'] = ', '.join(toaddrs)
         if pcc:
             headers['Cc'] = ', '.join(pcc)
-        headers['Date'] = formatdate()
+
+        default_tz = self.config.get('trac', 'default_timezone')
+        if default_tz:
+            self.env.log.debug("default_tz: %s" % default_tz)
+        else:
+            default_tz = formatdate()
+
+        headers['Date'] = default_tz
         msg = MIMEText(body, 'plain')
         # Message class computes the wrong type from MIMEText constructor,
         # which does not take a Charset object as initializer. Reset the

but doesn't do anything useful till I figured out what it supposed to hold. The default_timezone setting isn't documented in TracIni, what are valid options for this setting? Is there a list of this somewhere?

[Remy Blank]

Replying to thijstriemstra:

The default_timezone setting isn't documented in TracIni, what are valid options for this setting? Is there a list of this somewhere?

It can hold any timezone name, as supported by Trac for the simple timezones (see trac.util.datefmt​) and pytz if installed. The list of available values can be found in trac.util.datefmt.all_timezones.