Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8941 closed defect (fixed)

Non-clickable close button in webkit

Reported by: Chris <ctlajoie@…> Owned by: Chris <ctlajoie@…>
Priority: normal Milestone: 0.11.7
Component: version control/browser Version: 0.11.6
Severity: normal Keywords:
Cc: ctlajoie@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When viewing a file with annotations if you click on a revision, the revision info comes up in a div, but in any webkit-based browser, the close button isn't clickable. Looks like you ran into this problem with Mozilla and already had a workaround for it. I just added safari to the list, and it seems to work in both Safari and Chrome.

  • blame.js

     
    7777                .append($('<div>').html(data || "<strong>(no changeset information)</strong>"))
    7878              .appendTo("body");
    7979
    80             // workaround non-clickable "Close" issue in Firefox
    81             if ($.browser.mozilla)
     80            // workaround non-clickable "Close" issue in Firefox and Safari
     81            if ($.browser.mozilla || $.browser.safari)
    8282              message.find("div.inlinebuttons").next().css("clear", "right");
    8383 
    8484            show();

Attachments (0)

Change History (3)

comment:1 by Chris <ctlajoie@…>, 15 years ago

Cc: ctlajoie@… added

comment:2 by Remy Blank, 15 years ago

Milestone: 0.11.7
Resolution: fixed
Status: newclosed

Right, that was actually already fixed on trunk. Fix backported in [9029].

comment:3 by Remy Blank, 15 years ago

Owner: set to Chris <ctlajoie@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Chris <ctlajoie@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Chris <ctlajoie@…> to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.