#8916 closed defect (fixed)
[patch] util.get_module_path() cleanup
| Reported by: | Owned by: | Remy Blank | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | admin/web | Version: | 0.11-stable |
| Severity: | trivial | Keywords: | patch |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
replace spurious comment with a valid docstring remove orphaned imports
patch for 0.11dev
Attachments (1)
Change History (9)
by , 14 years ago
| Attachment: | get_module_path.diff added |
|---|
comment:1 by , 14 years ago
| Milestone: | → 0.12 |
|---|---|
| Owner: | set to |
I'm quite sure the obsolete imports have been removed already on trunk, as I made a pass with pylint. I'll fix the docstring.
comment:2 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in [8990]. However, the comment was correct: the function really does return the plugin from which a module is imported.
comment:3 by , 14 years ago
You're confusing me. Maybe it is used to determine plugin from which a module is imported, but what it does is determine path from which any module is imported. Not necessary the plugin.
Can you reopen this and check again?
comment:4 by , 14 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
And for most modules it will return path to site-packages/ without any plugin references.
comment:5 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
AFAICT, the function will return the path to the plugin if the plugin was installed as an egg, or through easy_install. OTOH, the initial comment referred to the first part of the function only. Hopefully [8992] is ok.
follow-up: 7 comment:6 by , 14 years ago
Much better, thanks. It would be nice to see this ported to 0.11 as well, because Trac Admin shows incorrect info for plugins not packaged as eggs (I hope Trac supports this scenario) and I am going to work a patch for 0.11 to fix this if time permits.
comment:7 by , 14 years ago
Replying to anatoly techtonik <techtonik@…>:
Much better, thanks. It would be nice to see this ported to 0.11 as well, because Trac Admin shows incorrect info for plugins not packaged as eggs (I hope Trac supports this scenario)
Unfortunately not. 0.11.6 was intended to be the last 0.11.x release, but we will probably have to make a 0.11.7 due to a few critical bugs. This issue is certainly not critical, so we won't include it.
and I am going to work a patch for 0.11 to fix this if time permits.
Please base your work on trunk, where the plugin admin panel has already been reworked (but probably still displays the information wrong in the case you describe).
comment:8 by , 14 years ago
Replying to rblank:
Please base your work on trunk, where the plugin admin panel has already been reworked (but probably still displays the information wrong in the case you describe).
The next version of Debian is likely to be shipped with Trac 0.11, so somebody will have to backport that patch anyway.
sane docstring for get_module_path()