page parameter "author" in "wiki_page_added" and "wiki_page_deleted" methods is empty

[bestkontakt@…]

By using the implemented methods from "IWikiChangeListener" I tried to get the author parameter from page (page.author). Every time the value is empty and author is unknown then.

[Remy Blank]

Indeed, this seems to be the case, as we don't update the .author field in WikiPage.save().

[Remy Blank]

Additional tests and fix for this issue.

[Remy Blank]

The patch above (against trunk) should fix the issue.

One thing I wasn't sure of: when creating a WikiPage for an existing page with version=None, the .version attribute is set to the latest version number, but .resource.version is still None. Is this intentional, or should .version and .resource.version always be synchronized?

[bestkontakt@…]

The patched model.py is still does not contain the .author filed in "wiki_page_deleted" method. Tried it for many times and it always was empty. Tried to set

self.author = author
self.comment = comment
self.time = t

in delete method but got an error then.

The other thing i watched is the empty .comment field (page.comment) in all methods from IWikiChangeListener.

[Remy Blank]

I'm afraid I don't understand what you are trying to do. Could you please attach the code of your Component implementing IWikiChangeListener and demonstrating the issue?

[Remy Blank]

Ah, now I understand. When a WikiPage is deleted, it tries to fetch the latest page version from the database. See [2248] for an explanation. I'm not sure how useful this behavior is, though.

[anonymous]

Sorry, I did not really understand how the 2248 can be usefull. I did following, I moved the code

if version is None or version == self.version:
            self._fetch(self.name, None, db)

on the top, before the code for deleting the page will be executed. So I can get data before the page will be deleted. But after deleting the page I get an error:

File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/web/main.py", line 467, in _dispatch_request
  dispatcher.dispatch(req)
File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/web/main.py", line 212, in dispatch
  resp = chosen_handler.process_request(req)
File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/wiki/web_ui.py", line 147, in process_request
  self._do_delete(req, versioned_page)
File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/wiki/web_ui.py", line 269, in _do_delete
  version=version, name=page.name))
File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/util/translation.py", line 40, in gettext_noop
  return safefmt(string, kwargs)
File "/Library/Python/2.6/site-packages/Trac-0.12multirepos_r0-py2.6.egg/trac/util/translation.py", line 33, in safefmt
  return string % kwargs

[Remy Blank]

What I meant is that the behavior you observe seems to be intentional (according to the commit message in [2248]), but I'm not sure if it really makes sense.

[Remy Blank]

Patch applied in [8915].