[Patch] Make Trac work on all platforms with environment paths containing non-ASCII characters

[mikael@…]

(This is my very first ticket here, I have scanned for duplicates, to the best of my knowledge, but found none.)

My account name is "Administratör" in WinXP, and the following happens when using trac-admin to upgrade wiki in my environment:

trac-admin abc wiki upgrade
  CamelCase already up to date.
  InterMapTxt already exists.
  InterTrac already up to date.
  InterWiki already up to date.
  PageTemplates already up to date.
  RecentChanges already up to date.
UnicodeDecodeError: ('ascii', 'C:\\Documents and Settings\\Administrat\xf6r\\App
lication Data\\Python-Eggs\\trac-0.12dev_r8812-py2.6.egg-tmp\\trac\\wiki\\defaul
t-pages\\SandBox', 37, 38, 'ordinal not in range(128)')

trac-admin seems to be choking on the ö letter.

[Christian Boos]

You're right, I also think there's no ticket about this.

Making Trac work on all platforms with environment paths containing non-ascii characters is something non-trivial.

[Christian Boos]

Milestone 1.0 deleted

[Thijs Triemstra <lists@…>]

Not sure why this was lowered in priority, since it breaks trac upgrades..?

[Remy Blank]

Because there's an easy workaround: don't put your Trac environment in a path containing non-ASCII characters.

[Thijs Triemstra <lists@…>]

Replying to rblank:

Because there's an easy workaround: don't put your Trac environment in a path containing non-ASCII characters.

Is this documented?

[Christian Boos]

Yes, under TracEnvironment#SomeUsefulTips. One could also add a word about this below TracInstall#CreatingaProjectEnvironment.

[Mikael Relbe]

I added a word about it below TracInstall@323#CreatingaProjectEnvironment.

[Thijs Triemstra <lists@…>]

Replying to mrelbe:

I added a word about it below TracInstall@323#CreatingaProjectEnvironment.

Thanks. I guess raising it's severity is appropriate as well.

[Thijs Triemstra]

Looks like there's actually a warning issued already​:

 try:
     unicode(env_path, 'ascii')
 except UnicodeDecodeError:
     printerr(_("Non-ascii environment path '%(path)s' not "
                       "supported.", path=env_path))
     sys.exit(2)

[Thijs Triemstra]

Replying to thijstriemstra:

Looks like there's actually a warning issued already​:

 try:
     unicode(env_path, 'ascii')
 except UnicodeDecodeError:
     printerr(_("Non-ascii environment path '%(path)s' not "
                       "supported.", path=env_path))
     sys.exit(2)

But this error fails to print, and throws:

$ trac-admin test-trac-Administratör upgrade wiki
Traceback (most recent call last):
  File "/usr/local/bin/trac-admin", line 9, in <module>
    load_entry_point('Trac==0.13dev-r10664', 'console_scripts', 'trac-admin')()
  File "/home/thijs/workspaces/opensource/trac-trunk/trac/admin/console.py", line 546, in run
    "supported.", path=env_path))
  File "/home/thijs/workspaces/opensource/trac-trunk/trac/util/translation.py", line 197, in gettext
    return _gettext()
  File "/home/thijs/workspaces/opensource/trac-trunk/trac/util/translation.py", line 194, in _gettext
    return safefmt(self.active.ugettext(string), kwargs)
  File "/home/thijs/workspaces/opensource/trac-trunk/trac/util/translation.py", line 33, in safefmt
    return string % kwargs
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 55: ordinal not in range(128)

Attached patch fixes that for me so the user at least knows what went wrong:

$ trac-admin test-trac-Administratör upgrade wiki
Non-ascii environment path '/home/thijs/workspaces/opensource/test-trac-Administratör' not supported.

[Thijs Triemstra]

against 0.13 trunk r10664

[Remy Blank]

unicode-path-8829.patch​ applied on 0.12-stable in [10683], thanks. I'm leaving this open for fixing the original issue.

[Thijs Triemstra]

Replying to rblank:

I'm leaving this open for fixing the original issue.

I'm renaming the ticket in that case.

[Remy Blank]

Preparing for 1.0.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed