#8816 closed defect (fixed)
Rename a milestone instead of create a new one.
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.7 |
| Component: | roadmap | Version: | 0.11.5 |
| Severity: | normal | Keywords: | milestone rename patch |
| Cc: | niels.reedijk@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description (last modified by )
Steps:
- Create a new milestone with an existing milestone name.
- After the warning of there is already an existing milestone with that name, I change the name to a new one, and submit.
- Then trac renames the old milestone name to the new one. And there is no new milestone created.
Trac: 0.11.5 Python: 2.5.4 (r254:67916, Apr 4 2009, 17:56:17) [GCC 4.3.3] setuptools: 0.6c9 SQLite: 3.6.10 pysqlite: 2.5.0 Genshi: 0.5.1 Pygments: 0.10 Subversion: 1.4.6 (r28521) jQuery: 1.2.6
Attachments (2)
Change History (10)
comment:1 by , 15 years ago
| Milestone: | → 0.11.6 |
|---|---|
| Owner: | set to |
comment:2 by , 15 years ago
| Milestone: | 0.11.6 → 0.11.7 |
|---|
0.11.6 is about to start testing, so we'll do that in the next release.
comment:3 by , 15 years ago
Re: my patch
I'm not sure whether the logic of doing the milestone rename is clear from the flow of the code, so perhaps it needs a comment to point that out.
follow-up: 5 comment:4 by , 15 years ago
| Cc: | added |
|---|---|
| Keywords: | patch added |
Add patch keyword (and sort of an attempt to 'bump' the patch)
follow-up: 6 comment:5 by , 15 years ago
| Description: | modified (diff) |
|---|
Replying to niels.reedijk@…:
Add patch keyword (and sort of an attempt to 'bump' the patch)
The "perfect" way to bump such a patch would be to add a functional test for it ;-)
See source:branches/0.11-stable/trac/ticket/tests/functional.py.
comment:6 by , 15 years ago
Replying to cboos:
Replying to niels.reedijk@…:
Add patch keyword (and sort of an attempt to 'bump' the patch)
The "perfect" way to bump such a patch would be to add a functional test for it ;-)
Here you are. As expected, it fails before the patch (because the original milestone disappeared) and it succeeds after the patch.
Enjoy!
comment:7 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch applied in [9052]. Thanks!
comment:8 by , 15 years ago
| Owner: | changed from to |
|---|
Ooh, bad! Confirmed here on 0.11-stable.