Edgewall Software
Modify

Opened 11 years ago

Closed 6 years ago

Last modified 6 years ago

#8791 closed defect (fixed)

default_handler activates wrong Menuitem

Reported by: st.vogelsang@… Owned by: Ryan J Ollos
Priority: low Milestone: 1.0.3
Component: rendering Version: 0.11-stable
Severity: normal Keywords: default_handler TicketModule bitesized
Cc: Branch:
Release Notes:

The View Tickets menu item is highlighted when TicketModule is the default_handler.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

1) to test add following line in configuration of trac trac.ini

[trac]
default_handler = TicketModule

2) open the default project page in browser, correct page will be shown but wrong menuitem is activated. (please have look at the screenshoot)

Attachments (1)

MenuBar.png (84.2 KB ) - added by st.vogelsang@… 11 years ago.
picture illustrates the error prone highlighting of the menu item bar

Download all attachments as: .zip

Change History (10)

by st.vogelsang@…, 11 years ago

Attachment: MenuBar.png added

picture illustrates the error prone highlighting of the menu item bar

comment:1 by Ryan Ollos <ryano@…>, 11 years ago

It looks to me that the underlying cause of this probably results in the same behavior we see when using the th:MenusPlugin: th:#4914.

comment:2 by Christian Boos, 11 years ago

Milestone: next-minor-0.12.x

comment:3 by Remy Blank, 11 years ago

Keywords: bitesized added

comment:4 by Ryan J Ollos, 6 years ago

Cc: Ryan J Ollos added

comment:5 by Ryan J Ollos, 6 years ago

Milestone: next-minor-0.12.x1.0.3
Owner: set to Ryan J Ollos
Status: newassigned

Proposed fix in log:rjollos.git:t8791.

comment:6 by Jun Omae, 6 years ago

I think that could use a compiled re object rather than calling re.match(...) each time.

-    ticket_path_re = r'/ticket/([0-9]+)$'
+    ticket_path_re = re.compile(r'/ticket/([0-9]+)$')

in reply to:  6 comment:7 by Ryan J Ollos, 6 years ago

Replying to jomae:

I think that could use a compiled re object rather than calling re.match(...) each time.

Thanks, I will include the suggested change to ticket_path_re.

comment:8 by Ryan J Ollos, 6 years ago

Cc: Ryan J Ollos removed
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [13158:13159], merged to trunk in [13160].

And we are off and running with the 1.0.3 development :)

comment:9 by Ryan J Ollos, 6 years ago

Description: modified (diff)
Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.