#8791 closed defect (fixed)
default_handler activates wrong Menuitem
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | low | Milestone: | 1.0.3 |
Component: | rendering | Version: | 0.11-stable |
Severity: | normal | Keywords: | default_handler TicketModule bitesized |
Cc: | Branch: | ||
Release Notes: |
The View Tickets menu item is highlighted when |
||
API Changes: | |||
Internal Changes: |
Description (last modified by )
1) to test add following line in configuration of trac trac.ini
[trac] default_handler = TicketModule
2) open the default project page in browser, correct page will be shown but wrong menuitem is activated. (please have look at the screenshoot)
Attachments (1)
Change History (10)
by , 15 years ago
Attachment: | MenuBar.png added |
---|
comment:1 by , 15 years ago
It looks to me that the underlying cause of this probably results in the same behavior we see when using the th:MenusPlugin: th:#4914.
comment:2 by , 15 years ago
Milestone: | → next-minor-0.12.x |
---|
comment:3 by , 15 years ago
Keywords: | bitesized added |
---|
comment:4 by , 10 years ago
Cc: | added |
---|
comment:5 by , 10 years ago
Milestone: | next-minor-0.12.x → 1.0.3 |
---|---|
Owner: | set to |
Status: | new → assigned |
Proposed fix in log:rjollos.git:t8791.
follow-up: 7 comment:6 by , 10 years ago
I think that could use a compiled re
object rather than calling re.match(...)
each time.
- ticket_path_re = r'/ticket/([0-9]+)$' + ticket_path_re = re.compile(r'/ticket/([0-9]+)$')
comment:7 by , 10 years ago
Replying to jomae:
I think that could use a compiled
re
object rather than callingre.match(...)
each time.
Thanks, I will include the suggested change to ticket_path_re
.
comment:8 by , 10 years ago
Cc: | removed |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Committed to 1.0-stable in [13158:13159], merged to trunk in [13160].
And we are off and running with the 1.0.3 development :)
picture illustrates the error prone highlighting of the menu item bar