Upgrade Failed - PostgreSQL backend

[brolewis <lewis.franklin@…>]

When attempting to perform an upgrade on a trac instance, I got the follow error message:

Command failed: Backup attempt failed (pg_dump: illegal option -- d
Try "pg_dump --help" for more information.)

I reviewed the code and found the issue in postgres_backend.py, line 117. Currently, the code reads:

args = [self.pg_dump_path, '-C', '-d', '-x', '-Z', '8']

However, in PostgreSQL 8.4, the "-d" flag was removed from pg_dump:

Remove -d and -D options from pg_dump and pg_dumpall (Tom)

These options were too frequently confused with the option to 
select a database name in other PostgreSQL client applications. 
The functionality is still available, but you must now spell out 
the long option name --inserts or --column-inserts.

Since the "—inserts" option remains, the args list should be instead:

args = [self.pg_dump_path, '-C', '--inserts', '-x', '-Z', '8']

[Remy Blank]

Thanks for the heads-up!

[Remy Blank]

Fixed in [8682], thanks!