[PATCH] bugzilla2trac.py - "sqlite3.IntegrityError" in addTicketChange()

[drm@…]

Exception raised: "sqlite3.IntegrityError: columns ticket, time, field are not unique"

The sqlite db layout seems to prohibit the changes stored in Bugzilla to happen at the same time in the same field. Bugzilla's db doesn't seem to work this way, since all changes in bugzilla are atomic and can follow each other up by one user's action, resulting in multiple changes in one field at the same time.

What I did to fix it was to add one second to the timestamp if the integrity exception occurred. I 've added a diff for this. It might be neater to implement a while loop though, in case there are even more than 2 changes at the same time (I'm not sure this happens at all).

Versions used are: trac 0.10.5 Bugzilla 2.20 Python 2.5 MySQL 5.0.51a (debian)

I didn't test it on other versions, but I probably will soon, since this was just a test run in a virtual machine.

[drm@…]

Patch

[drm@…]

I ran it on another system today with trac 0.11.1, and for some reason the pysqlite2 module was used in stead of sqlite3. Same patch applies, but I changed the relevant lines:

import sqlite3
import pysqlite2

and

except (sqlite3.IntegrityError, pysqlite2.dbapi2.IntegrityError):

With this patch, it works for 2200, so assigning to jruigrok as stated in bugzilla2trac.py. I'm not sure if some logic is needed to figure out which of the modules is used, and maybe just import the exception so the except block can read

except (IntegrityError): 

HTH :)

[Christian Boos]

Replying to drm@…:

… assigning to jruigrok as stated in bugzilla2trac.py.

Oops, this is no longer true, fixed in r9282.

[Carsten Klein <carsten.klein@…>]

Please note that on high traffic sites the above presented patch will still cause submission of a comment or rather change to an existing ticket to fail.

Perhaps it would be best to also include system nano time with the ticket change?

The best solution however, AFAIK would be to assign a unique id to each potential ticket change and also to remove the constraint of uniqueness on the change and making it a constraint on just the unique id, for example a uuid.

[manuel@…]

patch for debian lennz, bugzilla 3.2.4

[manuel@…]

While trying to do the import on Debian Lenny, with Bugzilla 3.2.4, I ran into two small issues:

• a collision between duplicate components. I suppose that is due to components with the same name in different bugzilla products
• an issue with the version resolution, or perhaps with the version at which the 'fieldid' field got renamed to 'id'

I guess this is not a very clean solution (there should perhaps be some dynamical renaming of the duplicate components, rather than replacement), but it may help others that are in the same situation than me.

[Remy Blank]

This should actually work now that we have microsecond timestamps. Please reopen if this is still an issue with a recent 0.12.x.

[Christian Boos]

(clearing report:35)