Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8714 closed enhancement (fixed)

Do not extract options from configuration if there is an option in Environment

Reported by: Felix Schwarz <felix.schwarz@…> Owned by: Felix Schwarz <felix.schwarz@…>
Priority: low Milestone: 0.12
Component: general Version: 0.12dev
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

In several places there is code to extract information from trac.ini/[project] which duplicates information as this is already available as an Option in Environment.

Attachments (1)

use_config_option_for_project_settings (3.0 KB ) - added by Felix Schwarz <felix.schwarz@…> 15 years ago.

Download all attachments as: .zip

Change History (6)

by Felix Schwarz <felix.schwarz@…>, 15 years ago

comment:1 by Remy Blank, 15 years ago

Owner: set to Remy Blank

I assume the usage of self.config.get() predates the creation of the descriptors that are now used.

comment:2 by Christian Boos, 15 years ago

Fine by me as well.

comment:3 by Remy Blank, 15 years ago

Resolution: fixed
Status: newclosed

Patch applied in [8636], thanks!

Felix, in the future, please attach your patches with a .patch extension, so that our beautiful patch viewer can be used :-)

comment:4 by Remy Blank, 15 years ago

Owner: changed from Remy Blank to Felix Schwarz <felix.schwarz@…>

in reply to:  3 comment:5 by Felix Schwarz <felix.schwarz@…>, 15 years ago

Replying to rblank:

Felix, in the future, please attach your patches with a .patch extension, so that our beautiful patch viewer can be used :-)

Sorry for that - I also forgot to put the commit comment in the patch header as suggested by cboos. Will do for future patches if you continue to merge my changes so fast ;-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Felix Schwarz <felix.schwarz@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Felix Schwarz <felix.schwarz@…> to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.