Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8667 closed defect (fixed)

trac should guard against errors when loading components

Reported by: Felix Schwarz <felix.schwarz@…> Owned by: Felix Schwarz <felix.schwarz@…>
Priority: normal Milestone: 0.12
Component: general Version: 0.11-stable
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Currently trac guards only against some exceptions​ when loading components from eggs. Others (e.g. NameError, SyntaxError) are not caught. I believe that this is an oversight: Probably every exception should be caught as in load_py_files.

Attachments (2)

Evil-1.0-py2.6.egg​ (1.3 KB ) - added by Felix Schwarz <felix.schwarz@…> 15 years ago.
example plugin that triggers the problem
8667_trac_should_guard_against_errors_when_loading_components​ (609 bytes ) - added by Felix Schwarz <felix.schwarz@…> 15 years ago.
proposed solutin

Download all attachments as: .zip

Change History (5)

by Felix Schwarz <felix.schwarz@…>, 15 years ago

Attachment: Evil-1.0-py2.6.egg​ added

example plugin that triggers the problem

by Felix Schwarz <felix.schwarz@…>, 15 years ago

Attachment: 8667_trac_should_guard_against_errors_when_loading_components​ added

proposed solutin

comment:1 by Remy Blank, 15 years ago

Milestone: → 0.12
Owner: set to Remy Blank

Makes sense.

comment:2 by Remy Blank, 15 years ago

Resolution: → fixed
Status: new → closed

Applied in [8623], and additionally print a full traceback for "unexpected" exceptions.

comment:3 by Remy Blank, 15 years ago

Owner: changed from Remy Blank to Felix Schwarz <felix.schwarz@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Felix Schwarz <felix.schwarz@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Felix Schwarz <felix.schwarz@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.