Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8630 closed enhancement (fixed)

Wrong "Adding plugin ..." reported in log file

Reported by: Augusto Roccasalva <augustoroccasalva@…> Owned by: Augusto Roccasalva <augustoroccasalva@…>
Priority: lowest Milestone: 0.12
Component: general Version: devel
Severity: trivial Keywords: plugin loader
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When Trac loads plugins from environment plugins folder, reports additions of distributions/packages that aren't plugins.

Example: 

2009-10-02 14:26:18,479 Trac[loader] DEBUG: Adding plugin Genshi 0.5.1 from
/usr/local/lib/python2.5/Genshi-0.5.1-py2.5-linux-i686.egg
2009-10-02 14:26:18,479 Trac[loader] DEBUG: Adding plugin setuptools 0.6c9 from
/usr/local/lib/python2.5/site-packages

This occurs because workgin_set.find_plugins() method returns a list of found plugins plus the dependencies for that plugin declared in setup.py file of plugin, dependencies that have already been added to working_set.

I think the solution could be filter distributions before are reported as added or even added to working_set. The patch attached fix this.

Attachments (1)

loader.patch​ (625 bytes ) - added by Augusto Roccasalva <augustoroccasalva@…> 15 years ago.
trac/loader.py Patch

Download all attachments as: .zip

Change History (4)

by Augusto Roccasalva <augustoroccasalva@…>, 15 years ago

Attachment: loader.patch​ added

trac/loader.py Patch

comment:1 by Christian Boos, 15 years ago

Keywords: plugin loader added
Milestone: → 0.12
Owner: set to Christian Boos

Thanks for the patch, will look into this.

comment:2 by Christian Boos, 15 years ago

Resolution: → fixed
Status: new → closed

Problem reproduced and fix tested. Committed in [8791].

Thanks!

comment:3 by Christian Boos, 15 years ago

Owner: changed from Christian Boos to Augusto Roccasalva <augustoroccasalva@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Augusto Roccasalva <augustoroccasalva@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Augusto Roccasalva <augustoroccasalva@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.