Wrong "Adding plugin ..." reported in log file

[Augusto Roccasalva <augustoroccasalva@…>]

When Trac loads plugins from environment plugins folder, reports additions of distributions/packages that aren't plugins.

Example:

2009-10-02 14:26:18,479 Trac[loader] DEBUG: Adding plugin Genshi 0.5.1 from
/usr/local/lib/python2.5/Genshi-0.5.1-py2.5-linux-i686.egg
2009-10-02 14:26:18,479 Trac[loader] DEBUG: Adding plugin setuptools 0.6c9 from
/usr/local/lib/python2.5/site-packages

This occurs because workgin_set.find_plugins() method returns a list of found plugins plus the dependencies for that plugin declared in setup.py file of plugin, dependencies that have already been added to working_set.

I think the solution could be filter distributions before are reported as added or even added to working_set. The patch attached fix this.

[Augusto Roccasalva <augustoroccasalva@…>]

trac/loader.py Patch

[Christian Boos]

Thanks for the patch, will look into this.

[Christian Boos]

Problem reproduced and fix tested. Committed in [8791].

Thanks!