Modify ↓
#8590 closed defect (fixed)
Signature of has_permission in MockPerm differs from PermissionCache
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.6 |
| Component: | general | Version: | 0.11-stable |
| Severity: | minor | Keywords: | testing |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I noticed MockPerm.has_permission has a different interface than PermissionCache.has_permission.
When the signature of MockPerm.has_permission is changed, please also change MockPerm's require and __call__ signatures so that they exactly accepts the same parameters as the PermissionCache (and not just any parameter) - otherwise some tests using MockPerm will succeed even though wrong parameters are used and the code will fail in production.
Attachments (1)
Change History (4)
comment:1 by , 15 years ago
| Milestone: | → 0.12 |
|---|
by , 15 years ago
| Attachment: | mockperm_signature added |
|---|
comment:2 by , 15 years ago
| Keywords: | testing added |
|---|---|
| Milestone: | 0.12 → 0.11.6 |
| Resolution: | → fixed |
| Status: | new → closed |
Patch applied in r8502.
It's good that you're using Mercurial patches (or was that generated with git?), but then you could as well prepare the commit message, which also has the advantage of making you less exposed to dubious jokes ;-)
comment:3 by , 15 years ago
| Owner: | set to |
|---|
Note:
See TracTickets
for help on using tickets.
Patch welcomed.