Edgewall Software
Modify ↓

Opened 16 years ago

Closed 16 years ago

#8573 closed enhancement (fixed)

Unified diffs generated by trac don't work with Review Board

Reported by: csapuntz@… Owned by: csapuntz@…
Priority: normal Milestone: 0.11.6
Component: version control/changeset view Version: 0.12dev
Severity: trivial Keywords: diff
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Review Board (reviewboard) requires two spaces or a tab between the pathname and revision.

The attached patch is against trunk but it'd make my life easier if it were applied to the 0.11 stable branch too.

Attachments (1)

trac-reviewboard-support.diff​ (834 bytes ) - added by csapuntz@… 16 years ago.
Patch to versioncontrol/web_ui/changeset.py

Download all attachments as: .zip

Change History (5)

by csapuntz@…, 16 years ago

Attachment: trac-reviewboard-support.diff​ added

Patch to versioncontrol/web_ui/changeset.py

comment:1 by anonymous, 16 years ago

how do you integrate with reviewboard if i may ask?

comment:2 by csapuntz@…, 16 years ago

We don't integrate - but it would be nice to be able to download the changeset from trac and upload it to reviewboard, which is enabled by this patch.

comment:3 by Christian Boos, 16 years ago

Milestone: → 0.11.6
Owner: set to csapuntz@…
Severity: normal → trivial

Indeed, both GNU diff and svn diff place a tab there.

comment:4 by Christian Boos, 16 years ago

Keywords: diff added
Resolution: → fixed
Status: new → closed

Patch applied in [8481]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain csapuntz@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from csapuntz@… to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.