Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#8532 closed defect (invalid)

NameError: global name 'GitErrorCommit_Id' is not defined

Reported by: arel Owned by:
Priority: normal Milestone:
Component: general Version: 0.11.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

How to Reproduce

While doing a GET operation on /browser/Online/DirName, Trac issued an internal error.

This appears to be a problem with Trac's handling of filenames with spaces in them when using git. To reproduce this, browse a git repository with two directories: one which contains files with no spaces, and the other which does.

I found a discussion with the (unacceptable) workaround of changing filenames with spaces to use underscores, which apparently works.

http://trac-hacks.org/ticket/4681

Request parameters:

{'path': u'/Online/DirName'}

User Agent was: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/530.19.2 (KHTML, like Gecko) Version/4.0.2 Safari/530.19

System Information

Trac 0.11.1
Python 2.5.2 (r252:60911, Jan 4 2009, 17:40:26)
[GCC 4.3.2]
setuptools 0.6c8
SQLite 3.5.9
pysqlite 2.5.0
Genshi 0.5.1
GIT 1.5.5.1
jQuery: 1.2.6

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.5/site-packages/trac/versioncontrol/web_ui/browser.py", line 361, in process_request
    'dir': node.isdir and self._render_dir(req, repos, node, rev),
  File "/usr/lib/python2.5/site-packages/trac/versioncontrol/web_ui/browser.py", line 408, in _render_dir
    changes = get_changes(repos, [i.rev for i in entries])
  File "/usr/lib/python2.5/site-packages/trac/versioncontrol/web_ui/util.py", line 38, in get_changes
    changeset = repos.get_changeset(rev)
  File "/usr/lib/python2.5/site-packages/tracext/git/git_fs.py", line 223, in get_changeset
    return GitChangeset(self.git, rev)
  File "/usr/lib/python2.5/site-packages/tracext/git/git_fs.py", line 389, in __init__
    (msg, props) = git.read_commit(sha)
  File "/usr/lib/python2.5/site-packages/tracext/git/PyGIT.py", line 486, in read_commit
    raise GitErrorCommit_Id
NameError: global name 'GitErrorCommit_Id' is not defined

Attachments (0)

Change History (2)

comment:1 by arel, 15 years ago

There appears to be a patch (but haven't tried it): http://trac-hacks.org/changeset/5378

comment:2 by John Hampton, 15 years ago

Resolution: invalid
Status: newclosed

OK, this is an issue with the GitPlugin. These issues should be reported on the http://trac-hacks.org site, not on this site.

Additionally, the ticket that you reference mentions that this issue should already be fixed in the latest version of the GitPlugin. Please try the latest version, and if it does not work, please create a ticket on the trac-hacks.org site

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.