Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 14 years ago

#85 closed defect (fixed)

Descriptive svn: links generate different links than standard svn: links.

Reported by: mrowe@… Owned by: Jonas Borgström
Priority: highest Milestone: 0.5.2
Component: wiki system Version: 0.5.1
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

When a link is created of the form svn:/aDirectory/ the link points to /log/aDirectory/. When the link is created as [svn:/aDirectory/ Description] the link points to /file/aDirectory/. This is problematic when /aDirectory/ is a directory as Trac attempts to retrieve the locations length from Subversion, generating an error.

This is caused by the fact that the fancysvnhref regular expression is listed after the more generic fancylink in svn:/trunk/trac/Wiki.py. Changing the order of the two regular expressions fixes the problem.

Attachments (0)

Change History (7)

comment:1 by anonymous, 16 years ago

Apologies for the bad formatting of the report.

comment:2 by daniel, 16 years ago

Priority: normalhighest
Severity: normalblocker

comment:3 by Jonas Borgström, 16 years ago

Status: newassigned

comment:4 by Jonas Borgström, 16 years ago

Resolution: fixed
Status: assignedclosed

Probably fixed in [195]. Please reopen this ticket if it's still broken.

The new behavour is as follows:

svn:/path and [svn:/path description]

both creates a link to trac.cgi/browser/path. The browser module will then display the directory contents, but the user will be redirected to trac.cgi/file/path if path points to a file instead of a directory.

comment:5 by mrowe@…, 16 years ago

Resolution: fixed
Severity: blockerminor
Status: closedreopened

Changeset [195] fixes the problem that I reported, but I am unsure whether redirecting to trac.cgi/file/path when path is a file is desirable behaviour. It makes more sense in my mind to redirect to trac.cgi/log/path in that case, as this allows the user to view either the file's contents or the changeset if they so desire.

comment:6 by Jonas Borgström, 16 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in [196].

Yes you are right. The new behaviour is as follows:

File links are now redirected to the log module unless a specific file revision is requested.

    svn:/path/file         will display the file log
    svn:/path/file#rev  will display the file contens for that revision.

comment:7 by Christian Boos, 14 years ago

Note that in 0.9 (and in 0.8 also, I'm pretty sure), the svn: prefix has no special meaning anymore:

  • svn:/trunk
  • svn:/trunk/README

Use source: prefix instead (browser: and repos: are also supported)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.