Edgewall Software
Modify

Opened 15 years ago

Closed 9 years ago

Last modified 9 years ago

#8471 closed defect (wontfix)

autocompletion in 'prepare diff' overrides text when tabbing out

Reported by: theultramage@… Owned by:
Priority: normal Milestone:
Component: version control Version: none
Severity: minor Keywords: anydiff suggest.js
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The autocompletion feature does not respond fast enough, so I usually type in the repository paths myself. However, after I type in the path I want, the suggestions menu pops up, with focus on another subdirectory (probably due to processing lag).

However, if I use 'tab' to jump to the next input box, the text I wrote into the first box gets replaced by the first path in the suggestions box. So I have to click somewhere to make the popup disappear, otherwise I lose the text that I typed in.

Attachments (0)

Change History (6)

comment:1 by ebray, 15 years ago

I think instead of autocompletion, it might be more useful to have a pop-up repository browser. I implemented such a thing for a file-select ticket field type, and users seem to like it.

comment:2 by Christian Boos, 14 years ago

Component: generalversion control
Keywords: anydiff added
Milestone: 0.12.1

comment:3 by Carsten Klein <carsten.klein@…>, 14 years ago

I think that the problem lies in js/suggest.js

        case 9:  // tab
        case 13: // return
        case 39: // right
          if (results) {
            var li = $("li.selected", results);
            if (li.length) {
              select(li);
              e.preventDefault();
            }
          }

does not check whether the user already has input something different to what is currently auto-selected in the suggesting box.

Last edited 9 years ago by Jun Omae (previous) (diff)

comment:4 by Ryan J Ollos, 9 years ago

Milestone: next-minor-0.12.xnext-stable-1.0.x

comment:5 by Ryan J Ollos, 9 years ago

Keywords: suggest.js added

comment:6 by Ryan J Ollos, 9 years ago

Milestone: next-stable-1.0.x
Resolution: wontfix
Status: newclosed

Closing as wontfix for 1.0-stable. suggest.js is replaced with jQuery-UI autocomplete for Trac 1.2 in #12169.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.