Add 'id' attribute to headings in the wiki

[dmurphy25@…]

By adding the 'id' attribute to the h* elements in the wiki, it would be possible to link to both a page and a specific section of the page.

e.g.

== Versions ==

…would become…

<h2 id="versions">Versions</h2>

… and could be linked to with [wiki:SomePage#versions].

It would also need to correct case/replace spaces with underscores in both the tag generation and link parsing.

[Christopher Lenz]

Why not add an id to any heading level?

[dmurphy25@…]

You're quite right - this should apply automatically to all hn elements.

[Christopher Lenz]

Ticket #992 has been marked as duplicate of this ticket. It contains a couple of patches.

[trac-form@…]

I have fixed all of cmlenz's issues with the original patch in #992. The fix for anchor uniqueness is based off the patch submitted by Manuzhai. I have also modified the TOC macro to use unique anchors and fixed a few other issues.

Patch is available ​here and TOC macro ​here.

[trac-form@…]

Actually, make that all of cmlenz's issues except the unit tests

;)

[Christopher Lenz]

Implemented in [1250].

For the TOC macro, note that IDs starting with a digit are prefixed with an underscore. So the macro will probably need to be updated.

[nil4@…]

To prevent anchor ids incrementing their numerical suffix forever, you should add a line:

class WikiFormatter:
  def __init__:
    ...
    self.anchors = []

Otherwise, every visit (or refresh) of the same wiki page generates different heading ids.

[Matthew Good <trac matt-good net>]

Well, I should note that the above id incrementing may not occur under CGI since the CGI will be run as a new process each time. So, I think that the anchor resetting would need tested under mod_python to reproduce the problem.

[Christopher Lenz]

Thanks, fixed in [1301].

[nil4@…]

Matthew: Sorry, I forgot to mention this issue occured under mod_python. The proposed patch fixes this problem.

cmlenz: Thanks for your quick reaction, and congratulations for making this outstanding product available to us all.

[nil4@…]

Matthew: Sorry, I forgot to mention this issue occured under mod_python. The proposed patch fixes this problem.

cmlenz: Thanks for your quick reaction, and congratulations for making this outstanding product available to us all.