[PATCH] Add an option to send filenames

[Emmanuel Blot]

Trac does not allow to send the name of a file being sent to the web client.

Although this option may not be useful with Trac core for now, this feature can be very useful for plugins that need to send files. The main use case for this feature is when the filename is generated: web client request for some data, and the plugin sends back a named file: without the proper content header, the browser gets the name from the URL, which may not match the actual filename.

Example:

1. client request: ​http://server/trac/plugin/get_file?parameters…
2. trac emits a file
3. client stores the received file based on the original URL, here 'get_file'

It would be nice to be able to send the actual file name to the client

See attached patch

[Emmanuel Blot]

Simple patch to send file name

[Remy Blank]

Instead of using a boolean send_name argument, I'd rather have an optional filename argument that allows the file name to be chosen arbitrarily. Files are not necessarily stored with the same name as appearing to the user. The file name should be quoted, too, but that's what content_disposition() is for (see the patch below).

OTOH, this would only be a convenience, as you can set the Content-Disposition header prior to calling send_file() (that's what the attachment module does).

OT: The filename argument of content_disposition() seems suspect to me, as it won't work if it is None. I'll fix that shortly.

[Remy Blank]

Aribtrary file name (untested)

[Remy Blank]

Replying to rblank:

OT: The filename argument of content_disposition() seems suspect to me, as it won't work if it is None. I'll fix that shortly.

Done in [8260].

[Remy Blank]

On second thought, I'd rather add a Content-Disposition header "manually" before calling send_file(), as this allows using either the inline or the attachment type.