Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8331 closed enhancement (fixed)

better_twill does not patch tc.fv

Reported by: Felix Schwarz <felix.schwarz@…> Owned by: Felix Schwarz <felix.schwarz@…>
Priority: low Milestone: 0.11.5
Component: general Version: 0.12dev
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

better_twill currently patches tc.formvalue​ so that a HTML page is stored if the form value could not be set.

However twill also contains the 'fv' function as a shorthand for 'formvalue' (which is actually used in trac's function mentioned above). This fv function is not replaced so it does not store HTML pages.

Please patch 'tc.fv' as well, e.g. add 'tc.fv = tc.formvalue' in line 174.

Attachments (0)

Change History (3)

in reply to:  description comment:1 by Remy Blank, 15 years ago

Milestone: → 0.11.5
Owner: set to Remy Blank

Replying to Felix Schwarz <felix.schwarz@…>:

However twill also contains the 'fv' function as a shorthand for 'formvalue' (which is actually used in trac's function mentioned above).

This is not quite true. The fv used in better_form_value() is a parameter of the function, set to tc.formvalue.

Still, your request is valid. I'll look into it.

comment:2 by Remy Blank, 15 years ago

Resolution: → fixed
Status: new → closed

Fixed in [8262]. Thanks for the patch!

comment:3 by Remy Blank, 15 years ago

Owner: changed from Remy Blank to Felix Schwarz <felix.schwarz@…>

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Felix Schwarz <felix.schwarz@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Felix Schwarz <felix.schwarz@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.